Apply search changes #505
Merged
Apply search changes #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
approved these changes
Dec 19, 2022
| * @param facetsDistribution Facets for which to retrieve the matching count | ||
| * @param showMatchesPosition Defines whether an object that contains information about the | ||
| * matches should be returned or not | ||
| * @param facets Facets for which to retrieve the matching count | ||
| * @param sort Sort queries by an attribute value | ||
| */ | ||
| public SearchRequest( |
There was a problem hiding this comment.
I'm begging for this issue be closed someday #455 haha
There was a problem hiding this comment.
Actually, I think it could be closed! I don't think we should keep those constructors anymore.
There was a problem hiding this comment.
Me too! But I prefer to finish the update before
alallema
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nbHitsresponse parameter toestimatedTotalHits.exhaustiveNbHitsresponse parameter.exhaustiveFacetsCountresponse parameter.matchesrequest parameter is renamedshowMatchesPosition.facetsDistributionrequest parameter is renamedfacets.facetsDistributionresponse parameter is renamedfacetDistribution.