Support user dictionary loading #491
Conversation
lib/meilisearch/index.rb
Outdated
| def dictionary | ||
| http_get("/indexes/#{@uid}/settings/dictionary") | ||
| end | ||
| alias get_dictionary dictionary |
There was a problem hiding this comment.
Same thing as the other PR, let's remove these aliases :)
There was a problem hiding this comment.
Same as the other PR, I am assuming you mean the getter only, and leaving the setter alias.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
=======================================
Coverage 99.60% 99.61%
=======================================
Files 9 9
Lines 509 516 +7
=======================================
+ Hits 507 514 +7
Misses 2 2
☔ View full report in Codecov by Sentry. |
|
Can you fix the conflicts here? |
ellnix
force-pushed
the
support-user-dictionary-loading
branch
2 times, most recently
from
6b16bf0 to
8707a48
Compare
Done. Rebased and force pushed, everything should be clean. Let me know if something else is required. |
493: Support text-separator customization r=brunoocasali a=ellnix # Pull Request ## Related issue Fixes #487 ## PR checklist Please check if your PR fulfills the following requirements: - [X] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [X] Have you read the contributing guidelines? - [X] Have you made sure that the title is accurate and descriptive of the changes? There are linter errors on both this pull request and the #491 since they add new settings, but they cannot reasonably be tackled while adding settings. A separate issue and PR would be more appropriate. Co-authored-by: ellnix <[email protected]> Co-authored-by: Bruno Casali <[email protected]>
|
Build failed: |
491: Support user dictionary loading r=brunoocasali a=ellnix # Pull Request ## Related issue Fixes #488 ## PR checklist Please check if your PR fulfills the following requirements: - [X] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [X] Have you read the contributing guidelines? - [X] Have you made sure that the title is accurate and descriptive of the changes? I attempted to keep to the repo's style and make as few edits as possible. Co-authored-by: ellnix <[email protected]>
|
@brunoocasali
I do not feel like these are problems that can be really addressed in this PR, perhaps some refactoring should be done? |
|
I think we can just regenerate the rubocop todo file, and then address those issues in a new PR :) |
|
Noted, will do first thing tomorrow. |
ellnix
force-pushed
the
support-user-dictionary-loading
branch
from
1e772d2 to
78459aa
Compare
|
@brunoocasali all done & rebased, should be good to go with 1 click. Sorry for being slow on the catch up, I wasn't familiar with the rubocop auto gen workflow. I will hang around to rebase the other PRs when this one gets merged. Thanks for the patience. |
|
I should thank you. In fact, you're doing an amazing job here! |
493: Support text-separator customization r=brunoocasali a=ellnix # Pull Request ## Related issue Fixes #487 ## PR checklist Please check if your PR fulfills the following requirements: - [X] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [X] Have you read the contributing guidelines? - [X] Have you made sure that the title is accurate and descriptive of the changes? There are linter errors on both this pull request and the #491 since they add new settings, but they cannot reasonably be tackled while adding settings. A separate issue and PR would be more appropriate. Co-authored-by: ellnix <[email protected]> Co-authored-by: Bruno Casali <[email protected]>
493: Support text-separator customization r=brunoocasali a=ellnix # Pull Request ## Related issue Fixes #487 ## PR checklist Please check if your PR fulfills the following requirements: - [X] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [X] Have you read the contributing guidelines? - [X] Have you made sure that the title is accurate and descriptive of the changes? There are linter errors on both this pull request and the #491 since they add new settings, but they cannot reasonably be tackled while adding settings. A separate issue and PR would be more appropriate. Co-authored-by: ellnix <[email protected]> Co-authored-by: Bruno Casali <[email protected]>
Pull Request
Related issue
Fixes #488
PR checklist
Please check if your PR fulfills the following requirements:
I attempted to keep to the repo's style and make as few edits as possible.