Skip to content

Conversation

@ktakiman
Copy link
Contributor

@ktakiman ktakiman commented Mar 5, 2023

Fix #888. When dap.ui.Layer.render is called with start == nil and end_ == nil, assign start = 0 only when the buffer contains a single, empty line. For all other cases, assign start == line-count instead of start == line-count - 1, which appears to be causing the line swapping issue.
Add a simple test case where the buffer already contains non-empty lines, and a new line is added with start == nil and end_ == nil, which should now be appended to the end.

@ktakiman ktakiman changed the title Fix for lines in scope widget go under a wrong group #888 Fix lines in scope widget go under a wrong group Mar 5, 2023
@mfussenegger mfussenegger merged commit 75a94b8 into mfussenegger:master Mar 6, 2023
@mfussenegger
Copy link
Owner

Thanks

@ktakiman
Copy link
Contributor Author

ktakiman commented Mar 7, 2023

Thank YOU for the great plugin 👍, and accepting my PR 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some lines in scope widget go under a wrong group

2 participants