Skip to content

Enable SCSS #952 Integration is not injecting the npm dependencies #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chl03ks opened this issue Jun 6, 2016 · 4 comments
Closed

Enable SCSS #952 Integration is not injecting the npm dependencies #971

chl03ks opened this issue Jun 6, 2016 · 4 comments

Comments

@chl03ks
Copy link
Contributor

chl03ks commented Jun 6, 2016

i'm trying to use the scss #952 integration in development mode is working fine but when i use the prod mode is not creating the '.css' for all the npm dependencies injected in the 'project.config.ts'

@chl03ks chl03ks changed the title Enable SCSS #952 Integration is not injecting the npm dependencies Enable SCSS #952 Integration is not injecting the npm dependencies Jun 6, 2016
@hankehly
Copy link
Contributor

hankehly commented Jun 6, 2016

@gvsdan, thank you for your comment. I'll take a look.

(update)
I verified that this is not working properly. I'll fix it and submit a PR asap.
Thank you for pointing this out.

@chl03ks
Copy link
Contributor Author

chl03ks commented Jun 7, 2016

@hank-ehly Thanks to you for making the sass support

mgechev added a commit that referenced this issue Jun 8, 2016
@TheDonDope
Copy link
Contributor

Fixed by #976, thank you very much Hank!

@chl03ks
Copy link
Contributor Author

chl03ks commented Jun 8, 2016

@hank-ehly Everything is working fine but now the external dependencies in production are broken.

i fixed the external dependencies adding this line in the build.html.css#processExternalCss

.pipe(isProd ? plugins.concatCss(CSS_PROD_BUNDLE,{rebaseUrls:false}) : plugins.util.noop())

Edit

the urls are getting modified in the prod mode. (example: fonts) #969 #850 @hank-ehly Any updates ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants