feature/enable-scss - issue #895 #952
Conversation
• SCSS stylesheets are ignored unless '--scss' flag is specified • Renamed methods ending in 'css' to more generic 'stylesheets'
• Reduced duplication by reusing SCSS processing method for all stylesheets • Added methods for finding SCSS files & their destinations based on wheth- er they are 'component' or 'external' stylesheets • Renamed methods ending in 'css' to more generic 'stylesheets'
|
@hank-ehly You will need to fix the linting errors as they fail CI |
|
+1 for this, much needed feature |
|
@d3viant0ne Understood. I'll deal with this asap. |
|
@hank-ehly great job! I restarted the AppVeyor build, tomorrow I'll review and merge. |
|
Put it in the wiki is better (IMO) |
|
We should update the Wiki article https://github.com/mgechev/angular2-seed/wiki/Add-Sass-support now that the PR is merged. |
|
@hank-ehly what is the other necessary minimum setup necessary to make use of the scss processing? Is renaming the |
|
The minimum requirements to enable SCSS processing are:
|
|
@hank-ehly Thank you! I will update the Wiki accordingly with this info. |
|
Thank you. I would like to note that setting the flag through project.config is currently not working. I apologize for not having researched further, but I believe it may be related to issue #823. |
|
@hank-ehly You are welcome. Yes, i updated the wiki article (https://github.com/mgechev/angular2-seed/wiki/Enabling-SASS-support) and included that info. Could you have a quick review it, if i described it correctly? Thank you! |
|
I just read the updated wiki page. Everything looks great! Hank |
|
this configuration is not working for build.prod is not injecting the NPM dependencies. |
Define stylesheet implementation of choice without manually editing the seed (#895 ).
--scssflag