Simplify and improve pywintypes search for dll in site-packages.#1933
Merged
mhammond merged 2 commits intomhammond:mainfrom Aug 22, 2022
Merged
Simplify and improve pywintypes search for dll in site-packages.#1933mhammond merged 2 commits intomhammond:mainfrom
mhammond merged 2 commits intomhammond:mainfrom
Conversation
The current method only looks at "global" and "user" site, which is not enough if pywin32 is installed in "system" site packages and imported from a venv created with --system-site-packages. With this updated approach, we avoid looking at each site separately and let the import statement find the location of pywin32_system32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1932
The current method only looks at "global" and "user" site,
which is not enough if pywin32 is installed in "system" site packages
and imported from a venv created with --system-site-packages.
With this updated approach, we avoid looking at each site separately
and let the import statement find the location of pywin32_system32.