Unfreeze setuptools version again, workaround#1936
Conversation
mhammond
left a comment
mhammond
left a comment
There was a problem hiding this comment.
Thanks for following up here, but I don't understand one of the changes.
| run: | | ||
| python setup.py bdist_wheel --skip-build | ||
|
|
||
| # 3.10 dropped support for bdist_wininst. If we had both 3.9 and 3.10 available in a single |
There was a problem hiding this comment.
Why this change? It means we don't get .exe installers from CI.
There was a problem hiding this comment.
The bdist_wininst has been completely removed recently from setuptools /distutils which is effective with current version of setuptools. (Commit message of 4. patch: Remove bdist_wininst from CI (gone in setuptools / distutils) -
Removed now in pypa/distutils@e28b6193 )
So its dead until some independent project would continue bdist_wininst or bdist_msi .
On the build machine you may use an older version of setuptools for some time if needed, or somehow fall back to deprecated legacy distutils in python (where the stub .exe were taken from anyway via setup.py/maybe_fixup_exes() ) ... ?
Or end .exe installers completely?
There was a problem hiding this comment.
Sorry the the delay and thanks for the explanation! Download stats of the .exe from github are quite minor compared to pypi, so I think I'll open an issue to phase them out, but might as well do that as late as practical. My local environment can still .exe installers, so 👍 and thanks!
after freeze in a22bd62. The workaround should become obsolete (silently) when distutils / setuptools is fixed midterm. Fix in Scintilla/makefile_pythonwin: nested nmake execution did not return errors (return code)
Newer distutils / setuptools versions already use and expose the MSVC & SDK dirs - taken from vcvarsall.bat . We need and should not use a different mechanism anymore. (Include & lib dirs of 2 different SDK kits at the same time were seen on compiler command lines on github CI - for the last months at least.)
kxrob
force-pushed
the
_unfreeze_setuptools
branch
from
686e0e1 to
b2110ac
Compare
2 participants
No description provided.