Stop building and alias winxpgui + fix ietoolbar demo#2217
Stop building and alias winxpgui + fix ietoolbar demo#2217Avasam merged 3 commits intomhammond:mainfrom
Conversation
| RECT *OUTPUT); | ||
| // @comm Only available in winxpgui | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Seems to be working perfectly fine for me:
>>> import win32gui
>>> gdi = win32gui.CreateRectRgnIndirect((0,0,1000,1000))
>>> window = win32gui.GetForegroundWindow()
>>> win32gui.SetWindowRgn(window, gdi, True)
>>> win32gui.GetWindowRgnBox(window)
[2, (0, 0, 1000, 1000)](even avoiding winxpgui to prove that it's working in this new build)
317c006 to
347da4c
Compare
mhammond
left a comment
There was a problem hiding this comment.
I like this, but my main concern is users who upgrade without uninstalling - depending on the PYTHONPATH order, there seems a good chance upgrading users might still find themselves loading the old winxpguidmodule.pyd. I'm not in a position to test that currently - are you able to?
|
If both the old Is that an issue? Most symbols were the exact same, built from win32gui. I guess we'd want to avoid a fresh install / full re-install from possibly causing some behavior change. Edit: or learn to do the exact same re-exports I'm doing, but in C (could maybe shortcut it using cythonize) and build the very simple module. |
Hrm, maybe not. I guess a risk is that later pywintypes.dll ends up changing symbols, meaning an old winxpgui fails to load. OTOH though, that seems an edge case so maybe it's fine. |
|
Ok, let's YOLO this given the benefit of killing this code is real and that risk I mentioned above is both theoretical and temporary |
|
If you're good with it, I'm good with it. It removes so much complexity and speeds up build times. |
As mentioned in https://mail.python.org/pipermail/python-win32/2024-March/014879.html
I went the very simple (and fast to "compile" 😉 ) route of having a pure python module that re-exports what we need.
To remove pywin32's own usage of
winxpguiin code, I had to touch theietoolbardemo, which I had to fix to test.I could remove it now, or leave it for a follow-up PR to keep this well-contained