Fixed unbound global variables in pywin.dialogs.ideoptions.OptionsPropPage's OnFormat* methods + re-enable pyright's reportUnboundVariable#2283
Merged
Avasam merged 9 commits intomhammond:mainfrom Nov 13, 2024
Conversation
Avasam
commented
Jun 4, 2024
pywin.dialogs.ideoptions.OptionsPropPage's OnFormat* methodspywin.dialogs.ideoptions.OptionsPropPage's OnFormat* methods + re-enable pyright's reportUnboundVariable
…opPage`'s `OnFormat*` methods
327b7a0 to
c624039
Compare
Avasam
commented
Oct 23, 2024
mhammond
requested changes
Nov 11, 2024
Owner
mhammond
left a comment
There was a problem hiding this comment.
This seems fine but I don't understand why the adodbapi change is in this. This also doesn't need a changelog.
Collaborator
Author
It's a reported unbound variable for Edit: Looks like it's done in #2324 so I probably forgot to split it off.
Ok ! |
mhammond
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at the implementation of
interact.SaveFontPreferencesthis almost certainly meant to use the variables ininteract. Although these still fail because callingself.GetFormatresults inAttributeError: 'PyCPropertyPage' object has no attribute 'GetFormat':For all I know these methods might always have been broken in the past 25 years. At least this allows us to turn on
reportUnboundVariablein pyright.