Add changelog entry for fixed adodbapi macro#2324
Merged
Avasam merged 13 commits intomhammond:mainfrom Mar 8, 2025
Merged
Conversation
This was referenced Jul 25, 2024
…nd-os-import-adodbapi
…nd-os-import-adodbapi
Avasam
changed the title
Owner
|
I don't understand why the .py change is in this PR? |
Collaborator
Author
Pretty sure that must've been some merge conflict slipping though, or accidentally included in a local commit push? Both version work though, and a lazy import kinda makes sense here given the other imports. |
mhammond
approved these changes
Mar 8, 2025
Owner
mhammond
left a comment
mhammond
left a comment
There was a problem hiding this comment.
Yeah, no real problem with the other change, it was just that this PR said it was docs only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was caught by pyright'sreportUnboundVariablewhich can be enabled when this and #2325 are merged.Macro was fixed in #2283 , so now this PR only adds the changelog entry