Skip to content

Fix last reportUndefinedVariable error #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Avasam merged 6 commits into from
Oct 13, 2024
+8 −9
Merged

Fix last reportUndefinedVariable error #2326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eb2e045
Fix last unbound error
Avasam Jul 26, 2024
db17015
update changes
Avasam Jul 26, 2024
38f283c
Merge branch 'main' of https://github.com/mhammond/pywin32 into Fix-l…
Avasam Oct 13, 2024
fc53379
Update CHANGES.txt
Avasam Oct 13, 2024
062af6c
Merge branch 'main' into Fix-last-unbound-error
Avasam Oct 13, 2024
ce7e49c
Update CHANGES.txt
Avasam Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Coming in build 309, as yet unreleased

* Improved handling of dict iterations (removes Python 2 support code, small general speed improvement) (#2332, @Avasam)
* Fixed "Open GL Demo" (`Pythonwin/pywin/Demos/openGLDemo.py`) and restore "Font" demo in `Pythonwin/pywin/Demos/guidemo.py` (#2345, @Avasam)
* Fixed accidentally trying to raise an undefined name instead of an `Exception` in `Pythonwin/pywin/debugger/debugger.py` (#2326, @Avasam)

Build 308, released 2024-10-12
------------------------------
Expand Down
13 changes: 6 additions & 7 deletions Pythonwin/pywin/debugger/debugger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,15 +869,14 @@ def RespondDebuggerState(self, state):
elif state == DBGSTATE_RUNNING: # Code is running under the debugger.
title = " - running"
elif state == DBGSTATE_BREAK: # We are at a breakpoint or stepping or whatever.
if self.bAtException:
if self.bAtPostMortem:
title = " - post mortem exception"
else:
title = " - exception"
else:
if not self.bAtException:
title = " - break"
elif self.bAtPostMortem:
title = " - post mortem exception"
else:
title = " - exception"
else:
raise error("Invalid debugger state passed!")
raise ValueError("Invalid debugger state passed!")
win32ui.GetMainFrame().SetWindowText(
win32ui.LoadString(win32ui.IDR_MAINFRAME) + title
)
Expand Down
3 changes: 1 addition & 2 deletions pyrightconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,8 @@
"reportOptionalSubscript": "warning",
// Needs fixes in types-pywin32 and requires Python 3.8 to annotate ambiguous global variables
"reportUnnecessaryComparison": "warning",
// TODO: Leave Unbound/Undefined to their own PR(s)
// TODO: Leave Unbound its own PR(s)
"reportUnboundVariable": "warning",
Copy link
Copy Markdown
Collaborator Author

@Avasam Avasam Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reportUnboundVariable done here:

"reportUndefinedVariable": "warning",
// Too many dynamically generated modules. This will require type stubs to properly fix.
"reportMissingImports": "warning",
// IDEM, but happens when pywin32 is not in site-packages but module is found from typeshed.
Expand Down