Basic support for definition export#170
Conversation
michaelklishin
left a comment
michaelklishin
left a comment
There was a problem hiding this comment.
Thank you for taking the time to contribute.
I'm afraid using interfaces for most entity collections is not something we would be interested in doing. This significantly reduces the amount of effort involved but makes it very hard to reason about the structure of responses.
You can use Hop as an example of a library that supports definition import and export in a more type-safe manner.
I'd understand if you decide against spending more time on this PR.
michaelklishin
changed the title
|
Hey,
Would it be ok if I replace all interfaces for specific types? I can improve it
…On Tue, 22 Dec 2020 at 22:33 Michael Klishin ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thank you for taking the time to contribute.
I'm afraid using interfaces for most entity collections is not something
we would be interested in doing. This significantly reduces the amount of
effort involved but makes it very hard to reason about the structure of
responses.
You can use Hop <https://github.com/rabbitmq/hop> as an example of a
library that supports definition import and export in a more type-safe
manner.
I'd understand if you decide against spending more time on this PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#170 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4YEQGLSEVY3M6C64HBZPTSWEGB3ANCNFSM4VEWE6VQ>
.
|
|
@pathcl sure, that's what I had in mind. Thank you. Can we please introduce a new type for global parameters? I can help get it over the finish line do it if you are not familiar with them. |
michaelklishin
left a comment
michaelklishin
left a comment
There was a problem hiding this comment.
This is definitely a step in the right direction. Let's also cover global parameters.
| } | ||
|
|
||
| // RuntimeDefinitions represents rabbitmq runtime configuration. | ||
| type RuntimeDefinitions struct { |
There was a problem hiding this comment.
They are called just definitions, not runtime definitions. A lot of them have nothing to do with runtime parameters and do not change at runtime (e.g. product version).
| // GET /api/definitions | ||
| // | ||
|
|
||
| func (c *Client) ListRuntimeDefinitions() (p *RuntimeDefinitions, err error) { |
There was a problem hiding this comment.
This should be renamed per the comment above.
|
Finished this and merged manually. Thank you. We may want to compare the global runtime parameters serialization to that of Hop but I'm reasonably confident in this feature as is. |
2 participants
Hello,
Nice library! thanks for making it open source. I tried to find a way to get whole rabbitmq configuration but couldn't find it.
Idea here is to get full config from rabbitmq runtime. Eventually this could be used along with terraform to eventually import/manage it.