Skip to content

Basic support for definition export #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelklishin merged 2 commits into from
Dec 26, 2020
Merged

Basic support for definition export #170

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
990478a
add runtime definitions for rabbitmq
pathcl Dec 21, 2020
e6e3be4
use types already defined instead
pathcl Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions runtime_parameters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,44 @@ type RuntimeParameter struct {
Value interface{} `json:"value"`
}

// RuntimeDefinitions represents rabbitmq runtime configuration.
type RuntimeDefinitions struct {

@michaelklishin michaelklishin Dec 26, 2020

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are called just definitions, not runtime definitions. A lot of them have nothing to do with runtime parameters and do not change at runtime (e.g. product version).

RabbitVersion string `json:"rabbit_version"`
RabbitMQVersion string `json:"rabbitmq_version"`
ProductName string `json:"product_name"`
ProductVersion string `json:"product_version"`
Users []UserInfo
Vhosts []VhostInfo
Permissions []Permissions
TopicPermissions []TopicPermissionInfo
Parameters []RuntimeParameter
GlobalParameters interface{} `json:"global_parameters"`
Policies []PolicyDefinition
Queues []QueueInfo
Exchanges []ExchangeInfo
Bindings []BindingInfo
}

// RuntimeParameterValue represents arbitrary parameter data.
type RuntimeParameterValue map[string]interface{}

//
// GET /api/definitions
//

func (c *Client) ListRuntimeDefinitions() (p *RuntimeDefinitions, err error) {

@michaelklishin michaelklishin Dec 26, 2020

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be renamed per the comment above.

req, err := newGETRequest(c, "definitions")
if err != nil {
return nil, err
}

if err = executeAndParseRequest(c, req, &p); err != nil {
return nil, err
}

return p, nil
}

//
// GET /api/parameters
//
Expand Down