A fix for CopyToClipboard functionality that does not work #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Fix CopyToClipboard Functionality #### Issue: The `CopyToClipboard` functionality does not work in Chrome Version 126.0.6478.127 (Official Build) (arm64), with no error messages provided. #### Root Cause: The `execCommand` function, which was previously used for copying text to the clipboard, is deprecated and no longer recommended as per [MDN documentation](https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand). This deprecation affects its reliability and compatibility across browsers. #### Solution: To address this issue, the fix implements a conditional approach: - **Primary Method:** Use the new [Clipboard API](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Interact_with_the_clipboard#browser_compatibility) if it is available. This API is more modern and secure, though not fully supported in all environments. - **Fallback Method:** If the Clipboard API is not supported, the function falls back to using `execCommand` to maintain compatibility with older browsers. #### Changes: - Added a check for Clipboard API availability. - Implemented the Clipboard API for copying text when supported. - Retained `execCommand` as a fallback to ensure broad compatibility. This approach ensures that the `CopyToClipboard` functionality works reliably across a range of browsers and versions, improving user experience and adhering to current web standards.
|
The Nevertheless, it's deprecated and not working on Firefox already So it would be great to get this merged 🙏 |
|
can be closed in favor of #37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CopyToClipboard Functionality
Issue:
The
CopyToClipboardfunctionality does not work in Chrome Version 126.0.6478.127 (Official Build) (arm64), with no error messages provided.Root Cause:
The
execCommandfunction, which was previously used for copying text to the clipboard, is deprecated and no longer recommended as per MDN documentation. This deprecation affects its reliability and compatibility across browsers.Solution:
To address this issue, the fix implements a conditional approach:
execCommandto maintain compatibility with older browsers.Changes:
execCommandas a fallback to ensure broad compatibility.This approach ensures that the
CopyToClipboardfunctionality works reliably across a range of browsers and versions, improving user experience and adhering to current web standards.