Use navigator.clipboard API when available #37
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Kikobeats
reviewed
Sep 11, 2024
Comment on lines
+29
to
+40
| if (navigator.clipboard) { | ||
| return await navigator.clipboard.writeText(textToCopy); | ||
| } else { | ||
| const container = document.createElement('textarea'); | ||
| container.innerHTML = textToCopy; | ||
| document.body.appendChild(container); | ||
| container.select(); | ||
| document.execCommand('copy'); | ||
| document.body.removeChild(container); | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| if (navigator.clipboard) { | |
| return await navigator.clipboard.writeText(textToCopy); | |
| } else { | |
| const container = document.createElement('textarea'); | |
| container.innerHTML = textToCopy; | |
| document.body.appendChild(container); | |
| container.select(); | |
| document.execCommand('copy'); | |
| document.body.removeChild(container); | |
| } | |
| return await navigator.clipboard.writeText(textToCopy); |
I think it's ok to assume navigator.clipboard.writeText is there
compat is +90% https://caniuse.com/mdn-api_clipboard_writetext
There was a problem hiding this comment.
agree, but then you can just replace await copyText with await navigator.clipboard.writeText(textToCopy);
|
I assume this would fix mac-s-g/react-json-view#131 ? |
|
I believe so, @SimonSchick |
|
Happy to merge this if someone update the PR with the suggested code 🙏 |
|
I would but am not authorized to change the PR. @architjain |
|
@mbtools just a new PR 🙂 |
mbtools
added a commit
to mbtools/react-json-view
that referenced
this pull request
Sep 26, 2024
Fixes issues with `document.execCommand('copy')` which is deprecated.
Uses `navigator.clipboard` instead which has [browser compatibility](https://caniuse.com/mdn-api_clipboard_writetext) of +93%.
Replaces microlinkhq#37
|
superseed by #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.