WIP: [docker] [ci] fix dockerfiles, test docker builds in CI #6638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
What about publishing these images somewhere? Eg. DockerHub, ghcr.io or quay.io. Do you think users need them?.. |
I don't think we should pursue pre-building the images and publishing them somewhere right now. I think that's a little too heavy for a single library like |
|
Fair enough! Agree with you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6450
Will hopefully prevent other issues similar to #6426 in the future.
Proposes the following:
$(arch)so the dockerfiles can be built on aarch64Notes for Reviewers
This is not ready for review.
As I work on this, I'll try to break off some pieces into other PRs to keep this from getting too big. Just opening this to show that I'm working on it.