[FancyZones Editor] New UX for the FZ editor. by SeraphimaZykova · Pull Request #9325 · microsoft/PowerToys

SeraphimaZykova · 2021-01-27T13:22:52Z

Summary of the Pull Request

This PR introduces a brand new UX for the FZ editor created by @niels9001

New features:

Ability to duplicate layouts
New UX that simplifies the creation and selection of (new) layouts.
Theming support (dark/light and all high contrast themes).
UI can now be fully controlled with tab/arrow keys
Monitor selection now supports keyboard (for selection)
Accessibility improvements.
Other minor enhancements (e.g. scrollable list).

Editor

New layout dialog

Edit template layout

Edit custom layout

Light theme

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

enricogior · 2021-01-27T14:11:14Z

-    /// </summary>
    public partial class CanvasEditorWindow : EditorWindow
    {
+        private int _offset = 100;


Can you add a comment to explain what is this offset referring to?

enricogior · 2021-01-27T14:20:47Z

@niels9001 @SeraphimaZ
you did an amazing work!!! 🥇

htcfreek · 2021-01-27T14:38:00Z

I agree with @enricogior. Thank you for this nice UI.

yuyoyuppe · 2021-01-27T14:42:17Z

+            Model.PropertyChanged += OnGridDimensionsChanged;
+
+            int zoneCount = _data.ZoneCount;
+            for (int i = 0; i <= zoneCount; i++)


shouldn't we do i < zoneCount instead?

Yes, but with a little fix in GridData. In fact, ZoneCount represents the biggest used index in the grid, so the name is misleading. I'll update the code so that it would represent exactly what it means.

htcfreek · 2021-01-27T14:45:12Z

@enricogior
Can we do layout based review too or do we only review the functional things to merge it for 0.31?

mykhailopylyp · 2021-01-27T15:26:25Z

        public App()
        {
-            DebugModeCheck();
+            // DebugModeCheck();


Why is it commented out? Should we remove it?

We still want to enable debug mode for stand alone debugging, we can revisit this in 0.33 or 0.35.

mykhailopylyp · 2021-01-27T15:54:20Z

+                }
+            }
+
+            _zoneCount = maxIndex + 1;


Before ZoneCount was equal to maxIndex not it is equal to maxIndex+1. Does it mean that indexing changed?

No, indexing wasn't changed. I explained above the reason for it, ZoneCount was a misleading name.

mykhailopylyp · 2021-01-27T16:09:31Z

 // The Microsoft Corporation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.

+using System;


nit: redundant using directive

Jay-o-Way · 2021-01-27T17:17:17Z

Looking good! 😁

May I make a few suggestions?
@ Editor: top part - I see you left away the resolution of the monitors. Is that for a specific reason? I believe that people like to see it.
@ New layout dialog - Top title mentions "type", but immediately below that there is an input for the name. Maybe "New layout" for the title and "Name" and "Type" labels would be a bit better? Are there any forbidden characters for the name? (to prevent the settings file from malfunctioning)
@ Edit (template) layout - A NumberBox for "Number of zones" and "Show space" and "Distance to highlight" would be better. I would mention "px" with the last two. Also we could combine the controls for Show space around zones?

niels9001 · 2021-01-27T17:38:54Z

Looking good! 😁
May I make a few suggestions?
@ Editor: top part - I see you left away the resolution of the monitors. Is that for a specific reason? I believe I've seen that people like to see it.

This has been moved into a tooltip, so hovering over / on focus would show the tooltip. Let's look at the feedback to see if it needs to be visible at all times.

@ New layout dialog - Top title mentions "type", but immediately below that there is an input for the name. Maybe "New layout" for the title and "Name" and "Type" labels would be a bit better?

Agree. I think the dialog title should just be "Create new layout".

@ Edit (template) layout - Maybe a NumberBox for "Number of zones" and "Show space" and "Distance to highlight" would be better. I would mention "px" with the last two aswel. Also we could combine the controls for Show space around zones?

The edit dialog probably needs some (minor) moving around of controls. Could you open an issue for that so it's track-able :)?

Jay-o-Way · 2021-01-27T17:54:57Z

        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        mc:Ignorable="d"
-        Title="Window1" Height="450" Width="800"
+        Title="Window1" Height="450"


crutkas · 2021-01-27T18:08:25Z

@enricogior, the installer build got stuck on a heart beat, i'm good to go if you are. I kicked off another one but it is only 1 minute into the actual compile.

Niels Laute and others added 30 commits January 27, 2021 15:23

Removed MetroWindow, added theming support and modernWPF

788f7ef

Rmoved MahApps refs

bb37479

Removed MahApps

4e2fc5a

Updated canvas zones

990b301

Updated GridEditor

5bab238

Fixes

14e17e3

UI updates

811d7c2

New layout type selection dialog

885496f

New editor UI

d0ff710

Updates

2601b08

Fix

4cd8d5c

UI enhancements

375f299

Updated UI

96c1c79

Added styles to layoutpreview

f77bed5

Accesibility improvements

61632b0

Accesibility and styling improvements

db8a8f9

Fix

439afd2

Cleaned up brushes

2adc597

Updated UX

257e7ec

Updated UI

4a95396

Added no layouts description

368be8a

Fix

257e88e

UI fixes

3289963

[FZ Editor] Serialize/deserialize settings (#8615)

0c85eab

conflicts fix

e0a68d5

[FZ Editor] Parse json file instead of command line args (#8649)

07c20a1

[FZ Editor] Serialize/deserialize settings fix (#8707)

39550a6

[FZ Editor] Hide unsupported settings in custom layouts flyouts (#8716)

31712d4

[FZ Editor] Duplicate custom layouts (#8718)

c9df94b

[FZ Editor] Duplicate layout behavior (#8720)

79961fd

address PR comments: updated colors

1afce88

enricogior reviewed Jan 27, 2021

View reviewed changes

yuyoyuppe reviewed Jan 27, 2021

View reviewed changes

SeraphimaZykova added 2 commits January 27, 2021 17:45

added comments, replaced magic numbers

b5b038a

refactoring

ea1021e

mykhailopylyp reviewed Jan 27, 2021

View reviewed changes

SeraphimaZykova added 2 commits January 27, 2021 19:15

merge zones crash fix

4e092e9

removed redundant using directive

1e26b18

enricogior approved these changes Jan 27, 2021

View reviewed changes

Jay-o-Way reviewed Jan 27, 2021

View reviewed changes

enricogior merged commit 646d61b into master Jan 27, 2021

SeraphimaZykova deleted the users/niels9001/fz-editorUXoverhaul branch January 27, 2021 18:34

Conversation

SeraphimaZykova commented Jan 27, 2021 • edited by enricogior Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

Quality Checklist

Contributor License Agreement (CLA)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

enricogior commented Jan 27, 2021

Uh oh!

htcfreek commented Jan 27, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

htcfreek commented Jan 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jay-o-Way commented Jan 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Looking good! 😁

Uh oh!

niels9001 commented Jan 27, 2021 • edited by enricogior Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

crutkas commented Jan 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

SeraphimaZykova commented Jan 27, 2021 •

edited by enricogior

Loading

htcfreek commented Jan 27, 2021 •

edited

Loading

Jay-o-Way commented Jan 27, 2021 •

edited

Loading

niels9001 commented Jan 27, 2021 •

edited by enricogior

Loading