Fix CredentialsContainer.store() return type

[lukewarlow]

The existing return type is wrong. This function returns an empty promise.

As can be seen in the specification and the MDN documentation.

https://w3c.github.io/webappsec-credential-management/#abstract-opdef-store-a-credential

https://developer.mozilla.org/en-US/docs/Web/API/CredentialsContainer/store

[github-actions]

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

[saschanaz]

MDN is wrong:

• Spec: https://w3c.github.io/webappsec-credential-management/#framework-credential-management
• Gecko implementation: https://searchfox.org/mozilla-central/rev/751e4466a7f4d3354727298d20abeecf39b33c40/dom/webidl/CredentialManagement.webidl#27
• WebKit: https://searchfox.org/wubkat/rev/aea708ebe4cafe961fc0f0c192d99eda3fe95c8b/Source/WebCore/Modules/credentialmanagement/CredentialsContainer.idl#34
• Blink: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/credentialmanagement/credentials_container.idl;l=10;drc=047c7dc4ee1ce908d7fea38ca063fa2f80f92c77

[lukewarlow]

Having ran it in the browser (tried Chrome with a password credentials) it also seems to return undefined?

const x = await navigator.credentials.store(new PasswordCredential({id: 'foo', password: 'foo', name: 'Foo'}));

[lukewarlow]

I will close this for now and file an issue on the spec itself because I don't think it's types are correct. Chrome is the only browser I know of that actually implements this API in a meaningful way so the browser type declarations are probably just matching the spec IDL which is wrong.

https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/credentialmanagement/credentials_container.cc#:~:text=ScriptPromise%20CredentialsContainer%3A%3Astore,ScriptPromiseResolver%3E(script_state)%3B Chrome's actual implementation doesn't match their IDL

[saschanaz]

Sounds like that's a bug in Blink, maybe file a bug in https://bugs.chromium.org/p/chromium/ ?

[lukewarlow]

@saschanaz idk if it requires manual work or if it will update automatically at some point but I've fixed this in the spec (not sure if it's published yet). It now correctly shows it returns an empty promise.

[saschanaz]

It's not being recognized because of w3c/webappsec-credential-management#213.