Skip to content

Fix build #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nsatragno opened this issue Mar 1, 2023 · 3 comments · Fixed by #223
Closed

Fix build #213

nsatragno opened this issue Mar 1, 2023 · 3 comments · Fixed by #223
Assignees
@sideshowbarker @nsatragno
Labels
editorial

Comments

@nsatragno
Copy link
Member

Fix the build. It is failing with "No 'dfn' refs found for 'parent browsing context'."
@nsatragno nsatragno self-assigned this Mar 1, 2023
@saschanaz saschanaz mentioned this issue Jul 7, 2023
Closed
@lukewarlow
Copy link
Member

Does this need a new reference or to just change it to not be a reference for now?

@sideshowbarker
Copy link
Member

I can help with this if needed

@nsatragno
Copy link
Member Author

Yeah I'd appreciate it. I can't easily find when the definition went away, and what the new equivalent is. Cheers!

@sideshowbarker sideshowbarker self-assigned this Jul 7, 2023
sideshowbarker added a commit that referenced this issue Jul 7, 2023
@sideshowbarker
Stop using “parent browsing context”; instead use “parent navigable”
0f3d896 
Fixes #213
@sideshowbarker sideshowbarker mentioned this issue Jul 7, 2023
Merged
sideshowbarker added a commit that referenced this issue Jul 7, 2023
@sideshowbarker
Stop using “parent browsing context”; instead just use “navigable” an…
f893ee7 
…d “parent”

Fixes #213
sideshowbarker added a commit that referenced this issue Jul 7, 2023
@sideshowbarker
Stop using “parent browsing context”; instead just use “navigable” an…
b5dd459 
…d “parent”

Fixes #213
sideshowbarker added a commit that referenced this issue Jul 7, 2023
@sideshowbarker
Use “navigable”+“parent”, not “parent browsing context”; fix fetch() …
d69fb24 
…refs

Fixes #213
sideshowbarker added a commit that referenced this issue Jul 7, 2023
@sideshowbarker
Use “navigable”+“parent”, not “parent browsing context”; fix fetch() …
ddd5952 
…refs

Fixes #213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sideshowbarker sideshowbarker

@nsatragno nsatragno

Labels
editorial
Projects
None yet
Milestone
No milestone
3 participants
@sideshowbarker @nsatragno @lukewarlow