Refactor to make sending PR easier #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The refactor looks OK to me. But there's a lot of code churn with no tests. How hard would be it to add a baseline kind of test to assert that refactorings don't change the last-known-good version of the emitted lib? |
|
@sandersn Good idea. For now I just used the |
|
OK, I added an issue for adding a baseline test. Otherwise looks OK. 👍 |
zhengbli
added a commit
that referenced
this pull request
Oct 22, 2015
Refactor to make sending PR easier
jeffryang24
added a commit
to jeffryang24/TSJS-lib-generator
that referenced
this pull request
Jun 15, 2019
sandersn
pushed a commit
that referenced
this pull request
Jun 20, 2019
* chore: add system state and capabilities whatwg spec * feat(idl): add generated widl and commentmap file * chore(baselines): add generated type * chore: update baseline * refactor(baseline): add removed ms-interfaces * refactor(idlSources): sort idlsource * refactor(addedTypes): add missing interfaces and MS-specific interfaces * refactor(overridingTypes): override navigator interface * refactor(overridingTypes): add missing ms-specific properties in Navigator interface * chore: update baselines * refactor(addedTypes): remove redundant interfaces * chore: update baselines #2 * refactor(addedTypes): remove MSLaunchUriCallback interface * refactor(knownTypes): add MSLaunchUriCallback inside Window field * chore: update baselines #3 (with node 12) * refactor(overridingTypes): restore NavigatorBeacon, activeVRDisplays, and getVRDisplays * chore: update baselines #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the word "dump" to "emit";
Move all the special definitions out of the source code to external json files, to make sending PRs easier;
And other clean-ups.