Update Navigator type #700

jeffryang24 · 2019-05-12T15:58:06Z

Changes

Add "HTML - System state and capabilities" spec from https://html.spec.whatwg.org/multipage/system-state.html.
Update some baseline files.
Add new generated webidl files.
Fix Possible typo for MimeTypeArray interface TypeScript#31358

msftclas · 2019-05-12T15:58:19Z

All CLA requirements met.

sandersn

There are a few MS-specific interfaces that are removed in this PR. Can you add them back manually unless you are sure that nobody is using them?

jeffryang24 · 2019-06-13T17:43:16Z

There are a few MS-specific interfaces that are removed in this PR. Can you add them back manually unless you are sure that nobody is using them?

I will try to add these specific interfaces back to the files. Sorry for my late response and thanks for notifying it... 👍

jeffryang24 · 2019-06-14T15:14:22Z

hmm... why the test still failed while my local success...? 🤔

sandersn · 2019-06-14T17:34:06Z

It's because dom.generated.d.ts is generated from various widl files plus some overriding jsons. You need to add MSFileSaver and MSNavigatorDoNotTracktoinputfiles/addedTypes.jsonand then add them toNavigatorininputfiles/overridingTypes.json`.

Here's an example of the first:

    "interfaces": {
        "interface": {
            "MSFileSaver": {
                "name": "MSFileSaver",
                "methods": {
                    "method": {
                        "msSaveBlob": {
                            "name": "msSaveBlob",
                            "override-signatures": [
                                "msSaveBlob(blob: any, defaultName?: string): boolean"
                            ]
                        }
// more methods here ...
                    }
                },
                "no-interface-object": 1
            },

Here's what I've got in overridingTypes.json for Navigator, but it's not working properly yet:

        "interface": {
            "Navigator": {
                "name": "Navigator",
                "extends": ["MSFileSaver", "MSNavigatorDoNotTrack"]
            },

I'll keep looking at the code and update when I figure it out. @saschanaz any suggestions?

saschanaz · 2019-06-15T01:01:21Z

You don't need to manually rewrite MSFileSaver, just do implements: ["MSFileSaver", "MSNavigatorDoNotTrack"] and it should automatically augment to the extends list and reuse existing types.

inputfiles/idlSources.json

jeffryang24 · 2019-06-15T04:38:47Z

You don't need to manually rewrite MSFileSaver, just do implements: ["MSFileSaver", "MSNavigatorDoNotTrack"] and it should automatically augment to the extends list and reuse existing types.

Hmm... what's different between extends and implements? For example below section:

"SVGFEDropShadowElement": {
                "name": "SVGFEDropShadowElement",
                "exposed": "Window",
                "properties": {
                    "property": {
                        "in1": {
                            "name": "in1",
                            "read-only": 1,
                            "override-type": "SVGAnimatedString"
                        },
                        "dx": {
                            "name": "dx",
                            "read-only": 1,
                            "override-type": "SVGAnimatedNumber"
                        },
                        "dy": {
                            "name": "dy",
                            "read-only": 1,
                            "override-type": "SVGAnimatedNumber"
                        },
                        "stdDeviationX": {
                            "name": "stdDeviationX",
                            "read-only": 1,
                            "override-type": "SVGAnimatedNumber"
                        },
                        "stdDeviationY": {
                            "name": "stdDeviationY",
                            "read-only": 1,
                            "override-type": "SVGAnimatedNumber"
                        }
                    }
                },
                "methods": {
                    "method": {
                        "setStdDeviation": {
                            "name": "setStdDeviation",
                            "override-signatures": [
                                "setStdDeviation(stdDeviationX: number, stdDeviationY: number): void"
                            ]
                        }
                    }
                },
                "extends": "SVGElement",
                "implements": [
                    "SVGFilterPrimitiveStandardAttributes"
                ]
            },

The output is: interface SVGFEDropShadowElement extends SVGElement, SVGFilterPrimitiveStandardAttributes.

saschanaz · 2019-06-15T04:43:33Z

The extends in WebIDL means it "inherits" from the target interface: SVGFEDropShadowElement.__proto__.prototype === SVGElement.prototype, while implements means it just includes their members (meaning they are mixins). It's really a WebIDL thing rather than TypeScript.

jeffryang24 · 2019-06-15T06:29:12Z

Hmm... My local test already success, but why it failed again..? 🤔

saschanaz · 2019-06-15T06:30:31Z

Hmm, it seems you should do rebase or merge from master branch.

jeffryang24 · 2019-06-15T06:31:39Z

Hmm, it seems you should do rebase or merge from master branch.

Ok, will merge from master first...

jeffryang24 · 2019-06-15T06:32:33Z

Currently already up to date with master.

…gator interface

saschanaz · 2019-06-15T06:38:49Z

inputfiles/addedTypes.json

@@ -2207,6 +2207,150 @@
                        }
                    }
                }
+            },
+            "MSFileSaver": {


All changes here in addedTypes.json look redundant. implements in overridingTypes.json should do these things automatically.

All the added interfaces in addedTypes? such as MSFileSaver, MSNavigatorDoNotTrack, ExceptionInformation, etc.?

Yup. They were once removed from the result because implements did not included them (so the code thought they were needless), but as you added them again via overridingTypes.json, now those should be kept intact without these manual typings.

But, some interfaces like MSLaunchUriCallback, ExceptionInformation, ConfirmSiteSpecificExceptionsInformation, StoreExceptionsInformation, and StoreSiteSpecificExceptionsInformation have been deleted, so I added it back manually through addedTypes.json.

That's because we have a type tracker that auto-deletes unreferenced/unexposed dictionaries and interfaces. Try removing them and building again, and you'll see those types won't be removed again 😁

saschanaz · 2019-06-15T07:01:33Z

The test failure seems to be from an ordering problem... What environment are you on? OS and node.js version, etc.

saschanaz · 2019-06-15T07:11:19Z

inputfiles/addedTypes.json

@@ -2207,6 +2207,20 @@
                        }
                    }
                }
+            },
+            "MSLaunchUriCallback": {
+                "name": "MSLaunchUriCallback",


Ah, this is a problem. Could you remove this and add MSLaunchUriCallback to "Window" field of knownTypes.json?

Ok, sure.. will mve it to knownTypes.json...

jeffryang24 · 2019-06-15T07:11:37Z

The test failure seems to be from an ordering problem... What environment are you on? OS and node.js version, etc.

OS: Office Notebook => Ubuntu 18.04 LTS (amd64), Personal Notebook (current): Manjaro Illyria 18.0.4 (amd64)
NodeJS: Office Notebook => lts/carbon (v8.15.1), Personal Notebook (current): lts/dubnium (v10.16.0)

saschanaz · 2019-06-15T07:16:47Z

I'm not sure what's the core problem yet but confirmed that we have a compatibility problem with Node.js 8/10. Updating to Node.js 12 fixes the problem.

jeffryang24 · 2019-06-15T07:18:16Z

I'm not sure what's the core problem yet but confirmed that we have a compatibility problem with Node.js 8/10. Updating to Node.js 12 fixes the problem.

I see... will switch node to v12... 👍

saschanaz · 2019-06-15T07:38:30Z

baselines/dom.generated.d.ts

@@ -10805,30 +10817,21 @@ declare var NavigationPreloadManager: {
 };

 /** The state and the identity of the user agent. It allows scripts to query it and to register themselves to carry on some activities. */
-interface Navigator extends NavigatorID, NavigatorOnLine, NavigatorContentUtils, NavigatorStorageUtils, MSNavigatorDoNotTrack, MSFileSaver, NavigatorBeacon, NavigatorConcurrentHardware, NavigatorUserMedia, NavigatorLanguage, NavigatorStorage, NavigatorAutomationInformation {
-    readonly activeVRDisplays: ReadonlyArray<VRDisplay>;


We should restore activeVRDisplays/getVRDisplays() and NavigatorBeacon. Looks good otherwise.

… and getVRDisplays

sandersn requested changes Jun 6, 2019

View reviewed changes

saschanaz reviewed Jun 15, 2019

View reviewed changes

inputfiles/idlSources.json Outdated Show resolved Hide resolved

jeffryang24 added 10 commits June 15, 2019 13:32

chore: add system state and capabilities whatwg spec

121241a

feat(idl): add generated widl and commentmap file

8fecd20

chore(baselines): add generated type

cddf826

chore: update baseline

479c74c

refactor(baseline): add removed ms-interfaces

9189f78

refactor(idlSources): sort idlsource

a3b0d1e

refactor(addedTypes): add missing interfaces and MS-specific interfaces

569dd99

refactor(overridingTypes): override navigator interface

5c8e19e

refactor(overridingTypes): add missing ms-specific properties in Navi…

21c1c0e

…gator interface

chore: update baselines

e61b35f

jeffryang24 force-pushed the fix-mimetypearray-interface branch from 081d8d2 to e61b35f Compare June 15, 2019 06:35

saschanaz reviewed Jun 15, 2019

View reviewed changes

jeffryang24 added 2 commits June 15, 2019 14:04

refactor(addedTypes): remove redundant interfaces

25ece2b

chore: update baselines microsoft#2

cfcded8

saschanaz reviewed Jun 15, 2019

View reviewed changes

jeffryang24 added 3 commits June 15, 2019 14:30

refactor(addedTypes): remove MSLaunchUriCallback interface

d0bf8e6

refactor(knownTypes): add MSLaunchUriCallback inside Window field

87875b3

chore: update baselines microsoft#3 (with node 12)

09e00f1

saschanaz reviewed Jun 15, 2019

View reviewed changes

saschanaz mentioned this pull request Jun 15, 2019

Sort members on dom.iterable.generated.d.ts #730

Merged

jeffryang24 added 2 commits June 15, 2019 14:48

refactor(overridingTypes): restore NavigatorBeacon, activeVRDisplays,…

ca26d7a

… and getVRDisplays

chore: update baselines microsoft#4

6384071

saschanaz mentioned this pull request Jun 15, 2019

Sort implements #731

Merged

sandersn approved these changes Jun 20, 2019

View reviewed changes

sandersn merged commit 7f5ab3c into microsoft:master Jun 20, 2019

jeffryang24 deleted the fix-mimetypearray-interface branch June 21, 2019 05:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Navigator type #700

Update Navigator type #700

jeffryang24 commented May 12, 2019

msftclas commented May 12, 2019 •

edited

Loading

sandersn left a comment

jeffryang24 commented Jun 13, 2019 •

edited

Loading

jeffryang24 commented Jun 14, 2019

sandersn commented Jun 14, 2019

saschanaz commented Jun 15, 2019

jeffryang24 commented Jun 15, 2019

saschanaz commented Jun 15, 2019 •

edited

Loading

jeffryang24 commented Jun 15, 2019

saschanaz commented Jun 15, 2019

jeffryang24 commented Jun 15, 2019

jeffryang24 commented Jun 15, 2019

saschanaz Jun 15, 2019 •

edited

Loading

jeffryang24 Jun 15, 2019

saschanaz Jun 15, 2019 •

edited

Loading

jeffryang24 Jun 15, 2019 •

edited

Loading

saschanaz Jun 15, 2019 •

edited

Loading

saschanaz commented Jun 15, 2019

saschanaz Jun 15, 2019

jeffryang24 Jun 15, 2019

jeffryang24 commented Jun 15, 2019

saschanaz commented Jun 15, 2019

jeffryang24 commented Jun 15, 2019

saschanaz Jun 15, 2019

Update Navigator type #700

Update Navigator type #700

Conversation

jeffryang24 commented May 12, 2019

msftclas commented May 12, 2019 • edited Loading

sandersn left a comment

Choose a reason for hiding this comment

jeffryang24 commented Jun 13, 2019 • edited Loading

jeffryang24 commented Jun 14, 2019

sandersn commented Jun 14, 2019

saschanaz commented Jun 15, 2019

jeffryang24 commented Jun 15, 2019

saschanaz commented Jun 15, 2019 • edited Loading

jeffryang24 commented Jun 15, 2019

saschanaz commented Jun 15, 2019

jeffryang24 commented Jun 15, 2019

jeffryang24 commented Jun 15, 2019

saschanaz Jun 15, 2019 • edited Loading

Choose a reason for hiding this comment

jeffryang24 Jun 15, 2019

Choose a reason for hiding this comment

saschanaz Jun 15, 2019 • edited Loading

Choose a reason for hiding this comment

jeffryang24 Jun 15, 2019 • edited Loading

Choose a reason for hiding this comment

saschanaz Jun 15, 2019 • edited Loading

Choose a reason for hiding this comment

saschanaz commented Jun 15, 2019

saschanaz Jun 15, 2019

Choose a reason for hiding this comment

jeffryang24 Jun 15, 2019

Choose a reason for hiding this comment

jeffryang24 commented Jun 15, 2019

saschanaz commented Jun 15, 2019

jeffryang24 commented Jun 15, 2019

saschanaz Jun 15, 2019

Choose a reason for hiding this comment

msftclas commented May 12, 2019 •

edited

Loading

jeffryang24 commented Jun 13, 2019 •

edited

Loading

saschanaz commented Jun 15, 2019 •

edited

Loading

saschanaz Jun 15, 2019 •

edited

Loading

saschanaz Jun 15, 2019 •

edited

Loading

jeffryang24 Jun 15, 2019 •

edited

Loading

saschanaz Jun 15, 2019 •

edited

Loading