Sort members on dom.iterable.generated.d.ts #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

orta merged 1 commit into microsoft:master from saschanaz:iterable-sort

Jul 23, 2019

Contributor

saschanaz commented Jun 15, 2019 •

edited

Loading

This fixes a compatibility issue with Node.js 8/10 where .sort() behaves differently with Node.js 12, by doing proper sort by name.

Thanks @jeffryang24 and sorry for the inconvenience! (#700 (comment))


          Sort members on dom.iterable.generated.d.ts

9aa7b02

saschanaz force-pushed the iterable-sort branch from 4986555 to 9aa7b02 Compare

June 15, 2019 09:39

Contributor

orta commented Jul 23, 2019

Thanks for this, my npm run test was failing

orta merged commit 353a0cf into microsoft:master

saschanaz deleted the iterable-sort branch

July 23, 2019 13:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet