-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Translate strict type checking options into zh #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR! This section of the codebase is owned by @Kingwl - if they write a comment saying "LGTM" then it will be merged. |
LGTM |
packages/tsconfig-reference/copy/zh/options/strictBindCallApply.md
Outdated
Show resolved
Hide resolved
…y.md Co-authored-by: 薛定谔的猫 <[email protected]>
@laosb PTAL. thanks! |
👋 hey folks, I've handled the merge conflict on this PR - if this PR is good to go, lets try get it in before friday. Otherwise I'll merge this PR at the end of the week, as it looks like a LGTM to me, because we're moving these PRs into their own repos re: #1480 |
Sorry @orta, you don't have access to merge: /packages/tsconfig-reference/copy/zh/categories/Strict_Type_Checking_Options_6173.md, /packages/tsconfig-reference/copy/zh/options/alwaysStrict.md, /packages/tsconfig-reference/copy/zh/options/noImplicitAny.md, /packages/tsconfig-reference/copy/zh/options/noImplicitThis.md, /packages/tsconfig-reference/copy/zh/options/strict.md, /packages/tsconfig-reference/copy/zh/options/strictBindCallApply.md, /packages/tsconfig-reference/copy/zh/options/strictFunctionTypes.md, /packages/tsconfig-reference/copy/zh/options/strictNullChecks.md, /packages/tsconfig-reference/copy/zh/options/strictPropertyInitialization.md. |
Well, that message could be improved. |
Thanks! I think It's basically done. so: LGTM |
Merging because @Kingwl is a code-owner of all the changes - thanks! |
#296