Skip to content

Translate strict type checking options into zh #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2021

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Oct 29, 2020

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @Kingwl - if they write a comment saying "LGTM" then it will be merged.

@garfeildma
Copy link

LGTM

@Kingwl
Copy link
Contributor Author

Kingwl commented Jan 18, 2021

@laosb PTAL. thanks!

@orta
Copy link
Contributor

orta commented Jan 25, 2021

👋 hey folks, I've handled the merge conflict on this PR - if this PR is good to go, lets try get it in before friday.

Otherwise I'll merge this PR at the end of the week, as it looks like a LGTM to me, because we're moving these PRs into their own repos re: #1480

@github-actions
Copy link
Contributor

Sorry @orta, you don't have access to merge: /packages/tsconfig-reference/copy/zh/categories/Strict_Type_Checking_Options_6173.md, /packages/tsconfig-reference/copy/zh/options/alwaysStrict.md, /packages/tsconfig-reference/copy/zh/options/noImplicitAny.md, /packages/tsconfig-reference/copy/zh/options/noImplicitThis.md, /packages/tsconfig-reference/copy/zh/options/strict.md, /packages/tsconfig-reference/copy/zh/options/strictBindCallApply.md, /packages/tsconfig-reference/copy/zh/options/strictFunctionTypes.md, /packages/tsconfig-reference/copy/zh/options/strictNullChecks.md, /packages/tsconfig-reference/copy/zh/options/strictPropertyInitialization.md.

@orta
Copy link
Contributor

orta commented Jan 25, 2021

Well, that message could be improved.

@Kingwl
Copy link
Contributor Author

Kingwl commented Jan 26, 2021

Thanks!

I think It's basically done. so:

LGTM

@github-actions github-actions bot merged commit 5b6485f into microsoft:v2 Jan 26, 2021
@github-actions
Copy link
Contributor

Merging because @Kingwl is a code-owner of all the changes - thanks!

@Kingwl Kingwl deleted the strict_check_zh branch January 26, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants