Skip to content

docs: translate zh-cn for tsconfig-reference/intro & cat #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 21, 2021
Merged

docs: translate zh-cn for tsconfig-reference/intro & cat #1327

merged 8 commits into from
Jan 21, 2021

Conversation

aladdin-add
Copy link
Contributor

@aladdin-add aladdin-add commented Nov 9, 2020 •
edited
Loading

refs: #296

@ghost
Copy link

ghost commented Nov 9, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@Kingwl
Copy link
Contributor

Kingwl commented Nov 25, 2020

Please take a look on: #1304 and #1295 too.
And I will review the pr after not WIP.

@aladdin-add
Copy link
Contributor Author

will review these PRs asap, thx!~

@aladdin-add aladdin-add changed the title wip:docs: translate zh-cn for tsconfig-reference/intro & cat docs: translate zh-cn for tsconfig-reference/intro & cat Dec 10, 2020
@Kingwl
Copy link
Contributor

Kingwl commented Dec 10, 2020

Seems not your fault.
You may try merge master and push again.

Let me known if it's ready for review.

@aladdin-add
Copy link
Contributor Author

merge master? but it was checkouted from v2 branch.

@aladdin-add
Copy link
Contributor Author

ptal! (the build failing seems not related to the change. 😌)

@Kingwl
Copy link
Contributor

Kingwl commented Dec 10, 2020

Sorry my bad. Merge v2 please.

@orta
Copy link
Contributor

orta commented Dec 10, 2020

good to me, unsure why the bot didn't ping this as mergeable though

@aladdin-add
Copy link
Contributor Author

@orta it might be the bot didn't get the PR is no longer a WIP (by removing "wip") 😄

@Kingwl I think it's ready to be reviewed.

@aladdin-add
Copy link
Contributor Author

friendly ping @Kingwl

@Kingwl
Copy link
Contributor

Kingwl commented Jan 18, 2021

friendly ping @laosb

@laosb
Copy link

laosb commented Jan 18, 2021

friendly ping @laosb

Will do after one of my final exams today. Sorry for delay.

laosb
laosb suggested changes Jan 18, 2021
View reviewed changes
Copy link

@laosb laosb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My cents here. Back to my preparation for next exam 😂.

@aladdin-add
Copy link
Contributor Author

果然通顺了很多！ 👍

@Kingwl
Copy link
Contributor

Kingwl commented Jan 20, 2021

Please merge v2 and push again.

Kingwl
Kingwl reviewed Jan 20, 2021
View reviewed changes
Copy link
Contributor

@Kingwl Kingwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT

@Kingwl
Copy link
Contributor

Kingwl commented Jan 20, 2021

OK. looks good.
I'd like to merge after test passed.

@Kingwl
Copy link
Contributor

Kingwl commented Jan 21, 2021

LGTM

@github-actions github-actions bot merged commit c2b80e6 into microsoft:v2 Jan 21, 2021
@github-actions
Copy link
Contributor

Merging because @Kingwl is a code-owner of all the changes - thanks!

@Kingwl
Copy link
Contributor

Kingwl commented Jan 21, 2021

Thanks!

@aladdin-add aladdin-add deleted the docs/zh-cn-tsconfig branch January 26, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kingwl Kingwl Kingwl left review comments

@laosb laosb laosb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aladdin-add @Kingwl @orta @laosb