VS 2013 save and compile output vs build compile output

[craigktreasure]

I have an enum in an interface that, when used in my TS code in TypeScript 1.3, was output as a constant. This is no longer the case in 1.4 after saving my file. When i build the project, the enum code is properly output as a constant. Using VS 2013 update 4 with TypeScript 1.4 installed.

Enum declaration file (Colors.d.ts):

declare module server {
    enum Colors {
        Red = 0,
        Green = 0,
        Blue = 0
    }
}

TS Code:

if(box.color === server.Colors.Red) {
...
}

JS Output after save:

if(box.color === server.Colors.Red) {
...
}

JS Output after build (correct, or what i consider to be correct since there is no implementation of the enum):

if(box.color === 0 /* Red */) {
...
}

The same is observed if the enum is declared using the new "const enum" feature.

[vladima]

Can you try the latest bits from master? It seems that root cause of this issue is the same with #1742 that was recently fixed

[craigktreasure]

What and where do I need to replace?

Sent from my Windows Phone

---

From: Vladimir Matveevmailto:[email protected]
Sent: ‎1/‎26/‎2015 3:06 PM
To: Microsoft/TypeScriptmailto:[email protected]
Cc: Craig Treasuremailto:[email protected]
Subject: Re: [TypeScript] VS 2013 save and compile output vs build compile output (#1812)

Can you try the latest bits from master? It seems that root cause of this issue is the same with #1742 that was recently fixed

---

Reply to this email directly or view it on GitHub:
#1812 (comment)

[vladima]

• run 'jake clean local' to build the TypeScript compiler\language service bits - build result will be dropped to 'build\local' folder
• go to <ProgramFiles>\Microsoft Visual Studio 12.0\Common7\IDE\CommonExtensions\Microsoft\TypeScript
• backup existing 'typescriptServices.js' somewhere and replace it with one that was build on the step 1

[basarat]

I've been getting this in 1.4 as well. Didn't investigate myself since I wasn't bothered but I've done many a commits like : TypeStrong/atom-typescript@ed04b58#diff-fe4e718ca060808778e53a950eb4764aL7 then again I had grunt, visual studio, and atom / ts language service fighting to build the same files :)

[craigktreasure]

@vladima A new copy of typescriptServices.js seems to have fixed the issue when i mark the enum declaration in the d.ts file as a const enum, but not for the scenario in which the enum is not a const enum.

[Stompf]

I've tried the new copy of typescriptServices.js and for me the problem still exists. It seems to work about 50% of the time when saving but in the other 50% it still compiles to the enum string (ex. server.Colors.Red in craigs example)

[craigktreasure]

In my case, I want it to compile to a constant since it is declared in a declaration file and they're isn't an implementation of the enum.

Sent from my Windows Phone

---

From: Stompfmailto:[email protected]
Sent: ‎1/‎27/‎2015 4:20 AM
To: Microsoft/TypeScriptmailto:[email protected]
Cc: Craig Treasuremailto:[email protected]
Subject: Re: [TypeScript] VS 2013 save and compile output vs build compile output (#1812)

I've tried the new copy of typescriptServices.js and for me the problem still exists. It seems to work about 50% of the time when saving but in the other 50% it still compiles to a constant

---

Reply to this email directly or view it on GitHub:
#1812 (comment)

[Stompf]

Yea I mixed up the words :) What I mean is that the output still sometimes is wrong like "server.Colors.Red" instead of "0 /* Red */" in your example for me when I save in VS 2013 even with updated typescriptServices.js. Tried edited my previous comment to reflect that

[vladima]

Can you write a short video with repro using Screen2Gif or similar tool? If you can please also capture the structure of the virtual project in Solution Navigator and set of files at the top of the screen

[Stompf]

Hello! I tried building the latest master again and now it works, I think I did something wrong the first time (sorry first time building from master). So you can disregard me.

[vladima]

@craigktreasure can you please provide a video with repro that will involve non const enums?

[craigktreasure]

@vladima I'll send a sample project your way later today.

[mrcrowl]

This looks the same as the issue I'm having in #1916.

Example project: https://www.dropbox.com/s/xc34f0q6rhc0amm/ExampleProject.zip?dl=0

[craigktreasure]

@vladima I believe this is fixed now.

[vytautas-pranskunas-]

I have replaced typescriptServices.js file and now on save it does not generate any file and console sys: "Input file contained syntax errors. Output generation skipped."

I do not have any errors and on build everything works fine.

[mhegazy]

Can you share a sample file where you are wrong this?

[vytautas-pranskunas-]

I dont know whic file exactly because after i pased same code to clean project it compile. However build passes with no errors. Console does not show anything on save except that error.

[mhegazy]

The issue would probably be linked to the contents of your project, it would help a lot if you can detect the code pattern that consistently triggers the issue.

[vytautas-pranskunas-]

Hello again,

I have found problem.
I reference

<Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\TypeScript\Microsoft.TypeScript.Default.props" Condition="Exists('$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\TypeScript\Microsoft.TypeScript.Default.props')" />

in my proj file and props file contains this line:

<TypeScriptNoEmitOnError>true</TypeScriptNoEmitOnError>

if I remove it everything compiles fine.

p.s. off topic: mshould i update ToolsVersion="4.0" in same file because of typescriptservices.js file changed?

p.p.s. one more offtopic question which i cannot find clear answer on the web - shuold i use delegate or method syntax in classes. In ecma6 there is methods syntax but delgates generates better javascript and prevents overriding. so:

class Boo {
boo(){} 
or 
boo = () => {}
}

[DanielRosenwasser]

Use method syntax, since it will be initialized once on the prototype. The property initializer will be set in the constructor body and a new closure may be created once per instantiation.

[vytautas-pranskunas-]

Ok. What about my main problem about compilation problem of typescript with props set?

[vytautas-pranskunas-]

There is nothing to share actually. Have you tried to add line I pasted before? Because as I mentioned before it stops to compile when this import is in .proj file

<Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\TypeScript\Microsoft.TypeScript.Default.props" Condition="Exists('$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\TypeScript\Microsoft.TypeScript.Default.props')" />

because of this line in that import

<TypeScriptNoEmitOnError>true</TypeScriptNoEmitOnError>

if you add to empty web project you should be able to reproduce it.

[mhegazy]

@vytautas-pranskunas- what kind of web project are you using. i am still not able to repro this issue with the different projects i tried.

[vytautas-pranskunas-]

I am doing it with empty MVC Web project.

[mhegazy]

I am sorry but i am still not able to get the same repro. Are you using VS2015 or VS2013? i have tried both with no luck, but just to be sure.

[vytautas-pranskunas-]

Vs2013. Its not only for me, its for all the team. Are you replacing only typescriptservices.js or something more?
I can create empty project and send it to you just tell me where.
But it just plain setup as i wrote before.

[mhegazy]

can you give TypeScript 1.5-Beta on VS2013 a try? it was just released :)

[vytautas-pranskunas-]

I defenetly will. Whats the best way to install it?

[vytautas-pranskunas-]

I defenetly will. Whats the best way to install it?

[mhegazy]

Here is the announcement: http://blogs.msdn.com/b/typescript/archive/2015/04/30/announcing-typescript-1-5-beta.aspx

here is the installer for VS2013: https://visualstudiogallery.msdn.microsoft.com/107f89a0-a542-4264-b0a9-eb91037cf7af

and the installer for VS2015 RC: https://visualstudiogallery.msdn.microsoft.com/3e5ba71c-abea-4d00-b81b-a62de3ad3d53

[vytautas-pranskunas-]

How this affects my MsBuild task? I mean I will have to update to 1.5 TS my CI server wouldn't I? I wonder can beta cause any problems to enterprise app build process?

[mhegazy]

The TypeScript targets have a property that specify which version of the compiler to use.

    <TypeScriptToolsVersion>1.4</TypeScriptToolsVersion>

if your project states 1.4 it will always build on the 1.4 compiler, even if you have 1.5 installed. so in this case you do not need to install it anywhere if you do not want to upgrade yet.

Installing the beta on production environments is up to your organizational policies.

What i am looking for is to get a way to reproduce the issue you are running into to be able to diagnose it. It would be great if you can try the same project with same setup on 1.5 to see if the problem still exists.

[vytautas-pranskunas-]

I have tried 1.5 beta:
After installing beta vs2013 throwed some errors about typescriptLanguages asking should it continue to show this error or not. After chosing "no" typescript compiler stoped generating .js files at all no matter what i did - tried to change ts version of the project and etc.
After uninstalling 1.5 i noticed that all tooling missing so i had to repair 1.4 :( after this everything went back to normal js files are generated except incorrect enums. When adding typescriptservices.js from alpha same as mentioned above happens.
Any thoughts?

[vytautas-pranskunas-]

Seems like after uninstalling 1.5 and re-installing 1.4 everything worked until vs restart. Now i get error when trying to build project because of incorrect typescript path Microsoft SDKa\TypeScript\1.4\1.4\tsc.exe
Seems like duplication of #2039
I have tried to repair typescript 1.4 but with no luck.
Any ideas how to fix this?

I was able to fix it but only by replacing TypeScript.dll taken from coworker in C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\TypeScript folder (uninstalling, re-installing and repairing did not helped). Looks like path was hard-coded in that .dll which might not be the best idea.

[mhegazy]

Can you share your install logs: %TEMP%\dd_TypeScript_*

[vytautas-pranskunas-]

Could you write full path to folder please?

[mhegazy]

well.. it depends where your temp folder is.. try:

echo %TEMP%

mine is at: C:\Users\mhegazy\AppData\Local\Temp

[vytautas-pranskunas-]

Give me an email where to send zip please

[mhegazy]

mhegazy at microsoft

[vytautas-pranskunas-]

We were still trying to fix that enum issue with cooworkers.
Those examples you did while trying to reproduce it - did you put enums to .d.ts file? Because while trying to fix it we noticed that enums placed in .ts files generates as expected but enums placed in defentition files generates:

1. On build - as expected (TestEnum.One = 1 turns to 1)
2. On save - wrong (TestEnum.One = 1 turns to TestEnum.One)

Can you try to put enums in definition file and use it other file's class and then do compile on save.

[mhegazy]

so you are still on 1.4? or have you managed to updated to 1.5? The issue did exist with 1.4, and we believe it has been fixed in 1.5.

[rwilliams-scottlogic]

It took me some digging to find the fix that was made, so here it is if anyone else also needs to patch their 1.4 typescriptServices.js: 4d14e97

It's on line 18265.

[craigktreasure]

@mhegazy I am hitting this again with the VS 2015 RTM and TS 1.5 with my project targeting 1.5. Enum definitions are not converted to constants. Any thoughts?

[mhegazy]

are they regular enums or const enums? can you share a repro?

[craigktreasure]

They are regular enums. Same repro as the first post when i opened this issue. Workaround is to mark the enum as a const enum in the definition, but that shouldn't be necessary.

[vladima]

this is breaking change in TypeScript 1.5:

For regular enums, pre 1.5, the compiler only inline constant members, and a member was only constant if its initializer was a literal. That resulted in inconsistent behavior depending on whether the enum value is initalized with a literal or an expression. Starting with Typescript 1.5 all non-const enum members are not inlined.

[craigktreasure]

Ouch. Good to know. I wish there had been a link to those in the 1.5 announcement post. If it was, i missed it.

[mhegazy]

Good point. Will do that next release. we usually put it in the release notes: https://github.com/Microsoft/TypeScript/releases/tag/v1.5.3