-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Type constraint lost in conditional type #43578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
mjbvz
added a commit
to mjbvz/vscode
that referenced
this issue
Apr 7, 2021
mjbvz
added a commit
to microsoft/vscode
that referenced
this issue
Apr 7, 2021
* Pick up new TS 4.3 Also tests adding override keywords for extensions as part of #120675 * Update to daily TS and workaround TS 4.3 issue Works around microsoft/TypeScript#43578
It's likely that #43439 changed something up if it's a difference since the beta. @ahejlsberg and @weswigham might want to take a look at this. |
That PR had a carve out for TypeParameters for compat - it can probably be relatively safely expanded to all TypeVariables to cover this case. |
digitarald
pushed a commit
to microsoft/vscode
that referenced
this issue
Apr 8, 2021
* Pick up new TS 4.3 Also tests adding override keywords for extensions as part of #120675 * Update to daily TS and workaround TS 4.3 issue Works around microsoft/TypeScript#43578
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this issue
Apr 8, 2021
* Pick up new TS 4.3 Also tests adding override keywords for extensions as part of microsoft#120675 * Update to daily TS and workaround TS 4.3 issue Works around microsoft/TypeScript#43578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
π Search Terms
π Version & Regression Information
4.3.0-dev.20210407
This was working in the TS 4.3 beta
β― Playground Link
https://www.typescriptlang.org/play?#code/KYDwDg9gTgLgBDAnmYcCCATDAxAllAZxgAUBDKUgW2BmCgBUJsBXAOwGMZcJWCAeeuQDmNAHxwAvHADeAKDgK4AbQDScXKzgBrYIggAzOIKgiYAXQBcR4TVVm4oWqwwE4ACgB0X4QSulWiEpmAJSS4gBuELgY8opxAPzuXh4+VmQU1LSEAjYwdqKhEhFRMXFxVpHRsgC+ANyyQA
π» Code
π Actual behavior
Parameters<Target[K]>
has the error:π Expected behavior
This code previously compiled without errors in the TS 4.3-beta
The text was updated successfully, but these errors were encountered: