Skip to content

Expand exception to contravariant constraint elision to all type variables #43599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2021
Merged

Expand exception to contravariant constraint elision to all type variables #43599

merged 3 commits into from
Apr 14, 2021

Conversation

weswigham
Copy link
Member

Fixes #43578

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Apr 8, 2021
@weswigham
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 8, 2021 •
edited
Loading

Heya @weswigham, I've started to run the tarball bundle task on this PR at 73d37f3. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 8, 2021 •
edited
Loading

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 73d37f3. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 8, 2021 •
edited
Loading

Heya @weswigham, I've started to run the perf test suite on this PR at 73d37f3. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 8, 2021 •
edited
Loading

Heya @weswigham, I've started to run the abridged perf test suite on this PR at 73d37f3. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 8, 2021 •
edited
Loading

Heya @weswigham, I've started to run the extended test suite on this PR at 73d37f3. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 8, 2021 •
edited
Loading

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 73d37f3. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 8, 2021 •
edited
Loading

Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/100539/artifacts?artifactName=tgz&fileId=EB733B4E549A25E2577BB70C33A86A4B1A37F3B80CCF992E01421E53EB3DAA0802&fileName=/typescript-4.3.0-insiders.20210408.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

@typescript-bot
Copy link
Collaborator

@weswigham
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..43599

Metric master 43599 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,904k (± 0.02%) 345,076k (± 0.02%) +172k (+ 0.05%) 344,894k 345,213k
Parse Time 1.93s (± 0.41%) 1.94s (± 0.77%) +0.01s (+ 0.41%) 1.91s 1.98s
Bind Time 0.83s (± 0.87%) 0.84s (± 0.58%) +0.01s (+ 1.44%) 0.83s 0.85s
Check Time 5.09s (± 0.26%) 5.22s (± 0.50%) +0.13s (+ 2.52%) 5.17s 5.29s
Emit Time 5.91s (± 0.60%) 5.93s (± 0.83%) +0.02s (+ 0.29%) 5.87s 6.10s
Total Time 13.76s (± 0.31%) 13.93s (± 0.58%) +0.16s (+ 1.20%) 13.82s 14.21s
Compiler-Unions - node (v10.16.3, x64)
Memory used 203,345k (± 0.03%) 203,395k (± 0.04%) +50k (+ 0.02%) 203,206k 203,562k
Parse Time 0.78s (± 0.43%) 0.79s (± 0.71%) +0.00s (+ 0.64%) 0.78s 0.80s
Bind Time 0.52s (± 1.13%) 0.52s (± 0.92%) -0.01s (- 1.34%) 0.51s 0.53s
Check Time 7.46s (± 0.58%) 7.49s (± 0.77%) +0.03s (+ 0.33%) 7.42s 7.64s
Emit Time 2.60s (± 1.35%) 2.58s (± 0.59%) -0.02s (- 0.92%) 2.53s 2.60s
Total Time 11.37s (± 0.55%) 11.37s (± 0.57%) -0.00s (- 0.04%) 11.24s 11.52s
Monaco - node (v10.16.3, x64)
Memory used 342,642k (± 0.02%) 342,745k (± 0.03%) +104k (+ 0.03%) 342,585k 343,125k
Parse Time 1.55s (± 0.52%) 1.56s (± 0.49%) +0.01s (+ 0.39%) 1.54s 1.57s
Bind Time 0.74s (± 0.92%) 0.74s (± 1.14%) +0.00s (+ 0.68%) 0.72s 0.76s
Check Time 5.26s (± 0.65%) 5.33s (± 0.47%) +0.07s (+ 1.37%) 5.27s 5.38s
Emit Time 3.12s (± 0.41%) 3.13s (± 0.64%) +0.00s (+ 0.13%) 3.08s 3.16s
Total Time 10.67s (± 0.37%) 10.75s (± 0.45%) +0.08s (+ 0.80%) 10.62s 10.86s
TFS - node (v10.16.3, x64)
Memory used 304,257k (± 0.02%) 304,310k (± 0.03%) +53k (+ 0.02%) 304,098k 304,508k
Parse Time 1.21s (± 0.48%) 1.21s (± 0.48%) +0.00s (+ 0.25%) 1.20s 1.22s
Bind Time 0.70s (± 0.93%) 0.71s (± 0.52%) +0.01s (+ 1.15%) 0.70s 0.71s
Check Time 4.72s (± 0.54%) 4.77s (± 0.50%) +0.06s (+ 1.21%) 4.72s 4.82s
Emit Time 3.25s (± 1.05%) 3.25s (± 0.97%) -0.00s (- 0.03%) 3.17s 3.32s
Total Time 9.87s (± 0.38%) 9.94s (± 0.34%) +0.07s (+ 0.67%) 9.85s 10.00s
material-ui - node (v10.16.3, x64)
Memory used 465,406k (± 0.02%) 466,078k (± 0.01%) +671k (+ 0.14%) 465,972k 466,187k
Parse Time 2.00s (± 0.70%) 2.01s (± 0.75%) +0.01s (+ 0.55%) 1.99s 2.05s
Bind Time 0.66s (± 0.98%) 0.66s (± 1.10%) +0.00s (+ 0.61%) 0.65s 0.68s
Check Time 14.22s (± 0.36%) 14.34s (± 0.57%) +0.13s (+ 0.90%) 14.24s 14.56s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.88s (± 0.29%) 17.02s (± 0.52%) +0.14s (+ 0.86%) 16.90s 17.26s
Angular - node (v12.1.0, x64)
Memory used 322,629k (± 0.03%) 322,749k (± 0.03%) +120k (+ 0.04%) 322,564k 322,985k
Parse Time 1.92s (± 0.52%) 1.93s (± 0.71%) +0.02s (+ 0.89%) 1.91s 1.96s
Bind Time 0.81s (± 0.55%) 0.82s (± 0.73%) +0.01s (+ 0.99%) 0.81s 0.83s
Check Time 5.00s (± 0.45%) 5.09s (± 0.37%) +0.09s (+ 1.84%) 5.05s 5.13s
Emit Time 5.97s (± 0.41%) 5.99s (± 0.53%) +0.02s (+ 0.42%) 5.94s 6.07s
Total Time 13.69s (± 0.31%) 13.83s (± 0.33%) +0.14s (+ 1.02%) 13.71s 13.92s
Compiler-Unions - node (v12.1.0, x64)
Memory used 190,339k (± 0.16%) 190,458k (± 0.12%) +119k (+ 0.06%) 189,943k 190,946k
Parse Time 0.77s (± 0.89%) 0.77s (± 0.94%) +0.01s (+ 0.78%) 0.76s 0.79s
Bind Time 0.53s (± 0.95%) 0.53s (± 1.25%) +0.00s (+ 0.95%) 0.52s 0.55s
Check Time 6.95s (± 0.38%) 7.01s (± 0.50%) +0.06s (+ 0.89%) 6.91s 7.08s
Emit Time 2.53s (± 0.89%) 2.55s (± 0.95%) +0.02s (+ 0.91%) 2.51s 2.62s
Total Time 10.76s (± 0.38%) 10.86s (± 0.44%) +0.10s (+ 0.88%) 10.73s 10.98s
Monaco - node (v12.1.0, x64)
Memory used 325,088k (± 0.02%) 325,184k (± 0.02%) +96k (+ 0.03%) 325,046k 325,274k
Parse Time 1.53s (± 0.71%) 1.54s (± 0.70%) +0.01s (+ 0.59%) 1.51s 1.56s
Bind Time 0.72s (± 0.56%) 0.71s (± 0.70%) -0.00s (- 0.56%) 0.71s 0.73s
Check Time 5.07s (± 0.50%) 5.16s (± 0.39%) +0.08s (+ 1.66%) 5.11s 5.19s
Emit Time 3.08s (± 0.47%) 3.09s (± 0.56%) +0.01s (+ 0.42%) 3.06s 3.15s
Total Time 10.40s (± 0.25%) 10.51s (± 0.31%) +0.10s (+ 0.99%) 10.44s 10.59s
TFS - node (v12.1.0, x64)
Memory used 288,785k (± 0.02%) 288,835k (± 0.01%) +50k (+ 0.02%) 288,749k 288,906k
Parse Time 1.21s (± 0.58%) 1.21s (± 0.48%) -0.00s (- 0.33%) 1.20s 1.22s
Bind Time 0.69s (± 0.68%) 0.69s (± 0.43%) +0.00s (+ 0.29%) 0.69s 0.70s
Check Time 4.64s (± 0.57%) 4.70s (± 0.42%) +0.06s (+ 1.31%) 4.65s 4.73s
Emit Time 3.16s (± 0.63%) 3.16s (± 0.83%) +0.00s (+ 0.03%) 3.10s 3.22s
Total Time 9.71s (± 0.44%) 9.76s (± 0.40%) +0.05s (+ 0.56%) 9.65s 9.84s
material-ui - node (v12.1.0, x64)
Memory used 443,470k (± 0.06%) 444,170k (± 0.01%) +700k (+ 0.16%) 444,058k 444,333k
Parse Time 2.03s (± 0.55%) 2.04s (± 0.74%) +0.01s (+ 0.74%) 2.02s 2.08s
Bind Time 0.64s (± 0.53%) 0.64s (± 1.32%) +0.00s (+ 0.31%) 0.63s 0.67s
Check Time 12.84s (± 0.49%) 12.92s (± 0.71%) +0.09s (+ 0.67%) 12.79s 13.24s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.51s (± 0.38%) 15.61s (± 0.59%) +0.10s (+ 0.66%) 15.47s 15.90s
Angular - node (v14.15.1, x64)
Memory used 321,325k (± 0.01%) 321,456k (± 0.01%) +131k (+ 0.04%) 321,401k 321,520k
Parse Time 1.93s (± 0.42%) 1.93s (± 0.44%) +0.00s (+ 0.05%) 1.91s 1.95s
Bind Time 0.86s (± 0.47%) 0.86s (± 0.67%) +0.00s (+ 0.47%) 0.85s 0.88s
Check Time 4.99s (± 0.55%) 5.10s (± 0.46%) +0.10s (+ 2.06%) 5.05s 5.16s
Emit Time 6.29s (± 0.55%) 6.31s (± 0.68%) +0.02s (+ 0.37%) 6.23s 6.43s
Total Time 14.08s (± 0.29%) 14.21s (± 0.41%) +0.13s (+ 0.92%) 14.11s 14.34s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,403k (± 0.02%) 189,501k (± 0.01%) +99k (+ 0.05%) 189,444k 189,548k
Parse Time 0.80s (± 0.72%) 0.80s (± 0.72%) 0.00s ( 0.00%) 0.79s 0.82s
Bind Time 0.55s (± 0.40%) 0.56s (± 0.65%) +0.01s (+ 0.91%) 0.55s 0.56s
Check Time 7.05s (± 0.47%) 7.08s (± 0.62%) +0.03s (+ 0.50%) 7.00s 7.21s
Emit Time 2.55s (± 0.54%) 2.54s (± 0.47%) -0.02s (- 0.67%) 2.51s 2.57s
Total Time 10.96s (± 0.37%) 10.98s (± 0.42%) +0.02s (+ 0.18%) 10.88s 11.10s
Monaco - node (v14.15.1, x64)
Memory used 324,044k (± 0.01%) 324,127k (± 0.01%) +83k (+ 0.03%) 324,082k 324,185k
Parse Time 1.56s (± 0.37%) 1.57s (± 0.43%) +0.01s (+ 0.90%) 1.56s 1.59s
Bind Time 0.74s (± 0.49%) 0.75s (± 0.59%) +0.01s (+ 1.08%) 0.74s 0.76s
Check Time 5.03s (± 0.44%) 5.10s (± 0.33%) +0.07s (+ 1.45%) 5.06s 5.13s
Emit Time 3.17s (± 0.53%) 3.18s (± 0.76%) +0.01s (+ 0.38%) 3.14s 3.24s
Total Time 10.50s (± 0.29%) 10.61s (± 0.37%) +0.11s (+ 1.03%) 10.55s 10.71s
TFS - node (v14.15.1, x64)
Memory used 287,658k (± 0.01%) 287,742k (± 0.01%) +84k (+ 0.03%) 287,686k 287,772k
Parse Time 1.26s (± 0.67%) 1.25s (± 1.15%) -0.01s (- 0.71%) 1.22s 1.29s
Bind Time 0.71s (± 0.63%) 0.71s (± 0.67%) +0.00s (+ 0.14%) 0.70s 0.72s
Check Time 4.65s (± 0.40%) 4.71s (± 0.38%) +0.05s (+ 1.12%) 4.66s 4.74s
Emit Time 3.24s (± 0.45%) 3.29s (± 0.43%) +0.05s (+ 1.64%) 3.26s 3.32s
Total Time 9.86s (± 0.22%) 9.96s (± 0.36%) +0.10s (+ 0.97%) 9.87s 10.03s
material-ui - node (v14.15.1, x64)
Memory used 441,589k (± 0.08%) 442,421k (± 0.01%) +832k (+ 0.19%) 442,379k 442,480k
Parse Time 2.09s (± 0.75%) 2.08s (± 0.56%) -0.00s (- 0.24%) 2.05s 2.11s
Bind Time 0.69s (± 0.80%) 0.69s (± 0.72%) +0.00s (+ 0.43%) 0.69s 0.71s
Check Time 13.04s (± 0.82%) 13.11s (± 0.72%) +0.07s (+ 0.54%) 12.92s 13.38s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.82s (± 0.72%) 15.88s (± 0.58%) +0.07s (+ 0.44%) 15.72s 16.15s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory10 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 43599 10
Baseline master 10

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

@weswigham
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..43599

Metric master 43599 Delta Best Worst
Angular - node (v14.15.1, x64)
Memory used 321,325k (± 0.01%) 321,414k (± 0.01%) +89k (+ 0.03%) 321,364k 321,481k
Parse Time 1.93s (± 0.42%) 1.93s (± 0.42%) -0.00s (- 0.16%) 1.91s 1.94s
Bind Time 0.86s (± 0.47%) 0.86s (± 0.43%) +0.01s (+ 0.70%) 0.86s 0.87s
Check Time 4.99s (± 0.55%) 5.10s (± 0.33%) +0.11s (+ 2.14%) 5.07s 5.13s
Emit Time 6.29s (± 0.55%) 6.34s (± 0.80%) +0.05s (+ 0.75%) 6.26s 6.48s
Total Time 14.08s (± 0.29%) 14.23s (± 0.43%) +0.16s (+ 1.10%) 14.13s 14.39s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,403k (± 0.02%) 189,520k (± 0.02%) +118k (+ 0.06%) 189,423k 189,564k
Parse Time 0.80s (± 0.72%) 0.81s (± 0.74%) +0.01s (+ 0.63%) 0.79s 0.82s
Bind Time 0.55s (± 0.40%) 0.55s (± 0.67%) +0.00s (+ 0.73%) 0.55s 0.56s
Check Time 7.05s (± 0.47%) 7.15s (± 0.93%) +0.10s (+ 1.38%) 7.02s 7.30s
Emit Time 2.55s (± 0.54%) 2.55s (± 0.72%) -0.01s (- 0.27%) 2.52s 2.60s
Total Time 10.96s (± 0.37%) 11.05s (± 0.70%) +0.09s (+ 0.86%) 10.90s 11.22s
Monaco - node (v14.15.1, x64)
Memory used 324,044k (± 0.01%) 324,131k (± 0.01%) +87k (+ 0.03%) 324,095k 324,179k
Parse Time 1.56s (± 0.37%) 1.57s (± 0.58%) +0.01s (+ 0.71%) 1.55s 1.59s
Bind Time 0.74s (± 0.49%) 0.74s (± 0.67%) +0.00s (+ 0.13%) 0.73s 0.75s
Check Time 5.03s (± 0.44%) 5.10s (± 0.50%) +0.07s (+ 1.47%) 5.05s 5.16s
Emit Time 3.17s (± 0.53%) 3.18s (± 0.84%) +0.01s (+ 0.41%) 3.15s 3.27s
Total Time 10.50s (± 0.29%) 10.60s (± 0.38%) +0.10s (+ 0.92%) 10.53s 10.71s
TFS - node (v14.15.1, x64)
Memory used 287,658k (± 0.01%) 287,738k (± 0.01%) +80k (+ 0.03%) 287,697k 287,765k
Parse Time 1.26s (± 0.67%) 1.26s (± 0.54%) +0.00s (+ 0.24%) 1.25s 1.28s
Bind Time 0.71s (± 0.63%) 0.71s (± 0.52%) +0.00s (+ 0.42%) 0.71s 0.72s
Check Time 4.65s (± 0.40%) 4.71s (± 0.40%) +0.06s (+ 1.22%) 4.67s 4.75s
Emit Time 3.24s (± 0.45%) 3.27s (± 0.63%) +0.03s (+ 0.96%) 3.23s 3.33s
Total Time 9.86s (± 0.22%) 9.96s (± 0.32%) +0.10s (+ 0.98%) 9.90s 10.07s
material-ui - node (v14.15.1, x64)
Memory used 441,589k (± 0.08%) 442,420k (± 0.00%) +832k (+ 0.19%) 442,382k 442,464k
Parse Time 2.09s (± 0.75%) 2.10s (± 0.47%) +0.01s (+ 0.43%) 2.08s 2.12s
Bind Time 0.69s (± 0.80%) 0.70s (± 1.91%) +0.01s (+ 0.72%) 0.68s 0.74s
Check Time 13.04s (± 0.82%) 13.04s (± 0.56%) +0.01s (+ 0.04%) 12.86s 13.21s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.82s (± 0.72%) 15.84s (± 0.41%) +0.02s (+ 0.14%) 15.72s 16.00s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-206-generic
Architecturex64
Available Memory16 GB
Available Memory10 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 43599 10
Baseline master 10

Developer Information:

Download Benchmark

@typescript-bot typescript-bot mentioned this pull request Apr 8, 2021
Open
@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@weswigham weswigham mentioned this pull request Apr 13, 2021
Closed
DanielRosenwasser
DanielRosenwasser approved these changes Apr 13, 2021
View reviewed changes
@weswigham weswigham merged commit 6c7c5e9 into microsoft:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@ahejlsberg ahejlsberg Awaiting requested review from ahejlsberg

Assignees

@weswigham weswigham

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type constraint lost in conditional type
3 participants
@weswigham @typescript-bot @DanielRosenwasser