Skip to content

Port #21343 to release-2.7 #21493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 29 commits into from
Closed

Port #21343 to release-2.7 #21493

wants to merge 29 commits into from

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Jan 30, 2018

Fixes #21491

mhegazy and others added 29 commits January 6, 2018 23:24
Port extract symbol fix to 2.7
[release-2.7] Allow dynamic files without external project and also use file names starting with ^ as dynamic file
[release-2.7] Rename internal function parseConfigFile to getParsedCommandLineOfConfigFile
[release-2.7] Simplify isEmittedFile check instead of iterating through all source files
* Use the full file path as the id for a submodule

* Informal code review feedback
Turns out SemicolonClassElement is a specific kind for semicolons inside
a class. Having one of them with --noUnusedLocals on would crash the
compiler after the assert added in #21013.
@mhegazy mhegazy closed this Jan 30, 2018
@mhegazy mhegazy deleted the port21343 branch January 31, 2018 18:43
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants