Fix handling of prologue statements when there are parameter property declarations #48775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parameter property declarations If there is a prologue (and no super) in a constructor, the prologue won't be skipped when calculating the parameter properties, leading to the prologue being included twice
typescript-bot
added
the
For Milestone Bug
|
|
|
Would you mind adding in the second test from #48771 (comment)? |
jlusty
commented
Apr 20, 2022
Comment on lines
-1366
to
+1372
| statements[0], | ||
| ...statements.slice(0, superAndPrologueStatementCount), |
There was a problem hiding this comment.
I've updated so we include parameter properties after any prologues - I believe this is the correct way of doing it, since that's what the existing TS version does
jakebailey
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
LGTM; notably, #29374 modified three transforms:
ts.ts, fixed in Fixed multiple prologue directives with parameter properties #48687es2015.ts, fixed in Fix constructor code when there is code between prologue statements and super call #48765classFields.ts, fixed in this PR.
I'm hoping that's the last of this bug.
|
@typescript-bot cherry-pick this to release-4.6 |
|
Heya @jakebailey, I've started to run the task to cherry-pick this into |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Apr 20, 2022
Component commits: 74c337b Fix handling of prologue statements when there are parameter property declarations If there is a prologue (and no super) in a constructor, the prologue won't be skipped when calculating the parameter properties, leading to the prologue being included twice bd2a2ec Add second test case d45098e Update to match old TS version: parameter properties after prologue 891cb6f Parametert properties should be added after any prologue
|
Hey @jakebailey, I've opened #48781 for you. |
This was referenced Apr 21, 2022
Jack-Works
pushed a commit
to Jack-Works/TypeScript
that referenced
this pull request
Apr 22, 2022
DanielRosenwasser
pushed a commit
that referenced
this pull request
May 5, 2022
Component commits: 74c337b Fix handling of prologue statements when there are parameter property declarations If there is a prologue (and no super) in a constructor, the prologue won't be skipped when calculating the parameter properties, leading to the prologue being included twice bd2a2ec Add second test case d45098e Update to match old TS version: parameter properties after prologue 891cb6f Parametert properties should be added after any prologue Co-authored-by: John Lusty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a chance to have a look into this, and I think I've found the solution to the issue I raised: if there is a prologue (and no super) in a constructor, the prologue won't be skipped when calculating the parameter properties, leading to the prologue being included twice.
Please let me know if I need to update/change anything - I hope I added the tests correctly, all the tests are still passing.
Fixes #48771