🤖 Pick PR #48775 (Fix handling of prologue statements...) into release-4.6 #48781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Component commits: 74c337b Fix handling of prologue statements when there are parameter property declarations If there is a prologue (and no super) in a constructor, the prologue won't be skipped when calculating the parameter properties, leading to the prologue being included twice bd2a2ec Add second test case d45098e Update to match old TS version: parameter properties after prologue 891cb6f Parametert properties should be added after any prologue
typescript-bot
added
the
For Uncommitted Bug
|
This unfortunately needs #48782 as the |
|
@DanielRosenwasser did you mean to merge this one in with the other two? |
|
Yup, I had to wait for CI to pass first, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-pick was triggered by a request on #48775
Please review the diff and merge if no changes are unexpected.
You can view the cherry-pick log here.
cc @jakebailey