Skip to content

Remove ts.{Map,Set,ESMap,Iterator} and associated types #51439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 9, 2022
Merged

Remove ts.{Map,Set,ESMap,Iterator} and associated types #51439

merged 4 commits into from
Nov 9, 2022

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Nov 8, 2022 •
edited
Loading

In #50049, I removed our shims for ts.Map and ts.Set, requiring that Map and Set be provided (either natively or by polyfill). Nobody complained.

In a recent design meeting, we seemed to agree that it'd be a good idea to drop all of our own Map/Set types for 5.0 (#49332 (comment)). This PR removes them.

This is good post-modules because we don't have to import these commonly used types.

Potentially I can restore the values (and only drop the types) if we are worried about people having written new ts.Map or new ts.Set. I'm not sure how worthwhile that is.

(This is technically the opposite of what we planned to do per the comments in the deprecated compat declarations, but we seemed to think it was fine during the meeting.)

@jakebailey jakebailey added Breaking Change Would introduce errors in existing code API Relates to the public API for TypeScript labels Nov 8, 2022
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 8, 2022
@jakebailey jakebailey mentioned this pull request Nov 8, 2022
Closed
5 tasks
@jakebailey jakebailey marked this pull request as draft November 8, 2022 22:07
@jakebailey
Copy link
Member Author

jakebailey commented Nov 9, 2022 •
edited
Loading

Checking sourcegraph, I think we may be safe to remove it wholesale.

The only apparent match is: https://github.com/aspect-build/rules_ts/blob/fe974b9255a1e777f62c157dfa07fc363c350225/ts/private/ts_project_worker.js#L707

@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 9, 2022 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at 3255f20. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..51439
Metric main 51439 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 341,130k (± 0.03%) 341,200k (± 0.01%) +70k (+ 0.02%) 341,024k 341,283k
Parse Time 1.54s (± 0.84%) 1.56s (± 0.43%) +0.01s (+ 0.78%) 1.54s 1.57s
Bind Time 0.54s (± 1.12%) 0.53s (± 1.22%) -0.00s (- 0.56%) 0.52s 0.55s
Check Time 3.99s (± 0.82%) 3.99s (± 0.66%) +0.00s (+ 0.03%) 3.94s 4.05s
Emit Time 4.21s (± 0.70%) 4.24s (± 0.93%) +0.03s (+ 0.69%) 4.18s 4.37s
Total Time 10.28s (± 0.45%) 10.32s (± 0.55%) +0.04s (+ 0.36%) 10.20s 10.49s
Compiler-Unions - node (v18.10.0, x64)
Memory used 189,934k (± 0.66%) 188,137k (± 1.05%) -1,797k (- 0.95%) 184,669k 190,444k
Parse Time 0.61s (± 1.22%) 0.62s (± 0.90%) +0.01s (+ 0.82%) 0.61s 0.63s
Bind Time 0.32s (± 1.12%) 0.33s (± 1.04%) +0.00s (+ 0.93%) 0.32s 0.33s
Check Time 4.96s (± 0.49%) 4.93s (± 0.40%) -0.03s (- 0.62%) 4.88s 4.97s
Emit Time 1.51s (± 0.59%) 1.53s (± 0.82%) +0.01s (+ 0.73%) 1.50s 1.56s
Total Time 7.42s (± 0.31%) 7.40s (± 0.37%) -0.01s (- 0.19%) 7.33s 7.47s
Monaco - node (v18.10.0, x64)
Memory used 320,513k (± 0.02%) 320,531k (± 0.02%) +18k (+ 0.01%) 320,428k 320,650k
Parse Time 1.14s (± 0.88%) 1.16s (± 1.19%) +0.01s (+ 1.05%) 1.13s 1.20s
Bind Time 0.48s (± 1.23%) 0.48s (± 0.70%) -0.00s (- 0.21%) 0.48s 0.49s
Check Time 3.82s (± 0.40%) 3.83s (± 0.52%) +0.01s (+ 0.31%) 3.80s 3.88s
Emit Time 2.22s (± 0.63%) 2.24s (± 0.79%) +0.02s (+ 0.72%) 2.19s 2.27s
Total Time 7.67s (± 0.34%) 7.71s (± 0.47%) +0.04s (+ 0.55%) 7.63s 7.79s
TFS - node (v18.10.0, x64)
Memory used 283,494k (± 0.24%) 283,837k (± 0.24%) +343k (+ 0.12%) 282,854k 284,845k
Parse Time 0.95s (± 0.87%) 0.95s (± 1.31%) +0.00s (+ 0.10%) 0.93s 0.99s
Bind Time 0.44s (± 1.38%) 0.44s (± 4.11%) +0.01s (+ 1.84%) 0.43s 0.51s
Check Time 3.77s (± 0.56%) 3.78s (± 0.70%) +0.01s (+ 0.40%) 3.72s 3.84s
Emit Time 2.18s (± 1.04%) 2.18s (± 0.68%) +0.01s (+ 0.32%) 2.16s 2.23s
Total Time 7.33s (± 0.60%) 7.36s (± 0.44%) +0.03s (+ 0.42%) 7.27s 7.42s
material-ui - node (v18.10.0, x64)
Memory used 435,960k (± 0.01%) 435,968k (± 0.01%) +9k (+ 0.00%) 435,897k 436,160k
Parse Time 1.33s (± 0.58%) 1.33s (± 0.58%) 0.00s ( 0.00%) 1.31s 1.35s
Bind Time 0.49s (± 0.91%) 0.49s (± 0.00%) +0.00s (+ 0.41%) 0.49s 0.49s
Check Time 10.24s (± 0.57%) 10.24s (± 0.59%) +0.01s (+ 0.05%) 10.16s 10.44s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 12.06s (± 0.52%) 12.06s (± 0.54%) +0.01s (+ 0.07%) 11.96s 12.28s
xstate - node (v18.10.0, x64)
Memory used 518,651k (± 0.01%) 518,635k (± 0.01%) -16k (- 0.00%) 518,550k 518,700k
Parse Time 1.91s (± 0.27%) 1.93s (± 0.58%) +0.02s (+ 0.94%) 1.91s 1.96s
Bind Time 0.78s (± 2.94%) 0.78s (± 2.74%) -0.00s (- 0.38%) 0.72s 0.82s
Check Time 1.03s (± 0.86%) 1.04s (± 0.67%) +0.01s (+ 0.48%) 1.03s 1.06s
Emit Time 0.05s (± 0.00%) 0.05s (± 4.37%) +0.00s (+ 2.00%) 0.05s 0.06s
Total Time 3.78s (± 0.60%) 3.80s (± 0.64%) +0.02s (+ 0.48%) 3.74s 3.84s
Angular - node (v16.17.1, x64)
Memory used 340,552k (± 0.02%) 340,562k (± 0.01%) +11k (+ 0.00%) 340,490k 340,645k
Parse Time 1.89s (± 0.71%) 1.88s (± 0.45%) -0.01s (- 0.42%) 1.86s 1.90s
Bind Time 0.65s (± 0.53%) 0.65s (± 0.56%) -0.00s (- 0.15%) 0.64s 0.65s
Check Time 5.14s (± 0.47%) 5.13s (± 0.60%) -0.02s (- 0.29%) 5.06s 5.19s
Emit Time 5.13s (± 0.87%) 5.10s (± 0.77%) -0.03s (- 0.58%) 5.02s 5.21s
Total Time 12.81s (± 0.42%) 12.76s (± 0.47%) -0.05s (- 0.43%) 12.62s 12.93s
Compiler-Unions - node (v16.17.1, x64)
Memory used 187,537k (± 0.59%) 187,242k (± 0.53%) -296k (- 0.16%) 186,523k 189,915k
Parse Time 0.79s (± 0.73%) 0.79s (± 1.26%) 0.00s ( 0.00%) 0.77s 0.82s
Bind Time 0.42s (± 0.00%) 0.42s (± 0.82%) -0.00s (- 0.71%) 0.41s 0.42s
Check Time 6.04s (± 0.44%) 6.02s (± 0.77%) -0.02s (- 0.40%) 5.92s 6.10s
Emit Time 1.89s (± 0.68%) 1.89s (± 0.81%) +0.00s (+ 0.16%) 1.87s 1.93s
Total Time 9.15s (± 0.38%) 9.12s (± 0.61%) -0.02s (- 0.24%) 9.03s 9.26s
Monaco - node (v16.17.1, x64)
Memory used 319,866k (± 0.01%) 319,832k (± 0.01%) -34k (- 0.01%) 319,777k 319,925k
Parse Time 1.43s (± 1.33%) 1.42s (± 0.49%) -0.01s (- 0.91%) 1.40s 1.43s
Bind Time 0.59s (± 0.38%) 0.59s (± 1.00%) +0.00s (+ 0.51%) 0.58s 0.61s
Check Time 4.88s (± 0.42%) 4.88s (± 0.43%) +0.00s (+ 0.02%) 4.84s 4.93s
Emit Time 2.73s (± 0.62%) 2.74s (± 0.87%) +0.01s (+ 0.37%) 2.66s 2.78s
Total Time 9.64s (± 0.34%) 9.63s (± 0.41%) -0.00s (- 0.04%) 9.51s 9.72s
TFS - node (v16.17.1, x64)
Memory used 282,277k (± 0.01%) 282,278k (± 0.02%) +1k (+ 0.00%) 282,045k 282,327k
Parse Time 1.16s (± 1.18%) 1.17s (± 0.92%) +0.01s (+ 0.69%) 1.15s 1.20s
Bind Time 0.67s (± 2.37%) 0.67s (± 3.32%) -0.01s (- 1.19%) 0.60s 0.69s
Check Time 4.76s (± 0.28%) 4.75s (± 0.70%) -0.01s (- 0.17%) 4.68s 4.82s
Emit Time 2.74s (± 2.30%) 2.74s (± 1.87%) +0.00s (+ 0.15%) 2.67s 2.86s
Total Time 9.33s (± 0.82%) 9.33s (± 0.75%) -0.00s (- 0.04%) 9.20s 9.55s
material-ui - node (v16.17.1, x64)
Memory used 435,293k (± 0.00%) 435,302k (± 0.00%) +9k (+ 0.00%) 435,271k 435,332k
Parse Time 1.65s (± 0.45%) 1.65s (± 0.51%) +0.00s (+ 0.12%) 1.63s 1.66s
Bind Time 0.50s (± 0.80%) 0.50s (± 0.73%) -0.00s (- 0.60%) 0.49s 0.50s
Check Time 11.92s (± 0.79%) 11.81s (± 0.62%) -0.11s (- 0.89%) 11.62s 11.96s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.07s (± 0.65%) 13.96s (± 0.54%) -0.11s (- 0.78%) 13.75s 14.11s
xstate - node (v16.17.1, x64)
Memory used 516,264k (± 0.01%) 516,261k (± 0.01%) -4k (- 0.00%) 516,184k 516,381k
Parse Time 2.32s (± 0.24%) 2.33s (± 0.29%) +0.00s (+ 0.22%) 2.31s 2.34s
Bind Time 0.85s (± 2.25%) 0.83s (± 0.71%) -0.01s (- 1.53%) 0.82s 0.84s
Check Time 1.35s (± 0.61%) 1.36s (± 0.60%) +0.00s (+ 0.15%) 1.34s 1.38s
Emit Time 0.06s (± 0.00%) 0.06s (± 0.00%) 0.00s ( 0.00%) 0.06s 0.06s
Total Time 4.59s (± 0.50%) 4.58s (± 0.26%) -0.01s (- 0.20%) 4.55s 4.60s
Angular - node (v14.15.1, x64)
Memory used 334,037k (± 0.01%) 334,049k (± 0.00%) +12k (+ 0.00%) 334,024k 334,078k
Parse Time 2.05s (± 0.78%) 2.04s (± 0.42%) -0.00s (- 0.20%) 2.03s 2.07s
Bind Time 0.70s (± 0.80%) 0.70s (± 0.43%) +0.00s (+ 0.00%) 0.69s 0.70s
Check Time 5.48s (± 0.46%) 5.48s (± 0.34%) +0.00s (+ 0.04%) 5.45s 5.54s
Emit Time 5.20s (± 0.52%) 5.19s (± 0.83%) -0.01s (- 0.17%) 5.08s 5.29s
Total Time 13.42s (± 0.41%) 13.41s (± 0.41%) -0.01s (- 0.07%) 13.31s 13.60s
Compiler-Unions - node (v14.15.1, x64)
Memory used 181,876k (± 0.41%) 181,567k (± 0.02%) -310k (- 0.17%) 181,486k 181,631k
Parse Time 0.89s (± 0.75%) 0.90s (± 0.56%) +0.01s (+ 0.90%) 0.89s 0.91s
Bind Time 0.45s (± 0.80%) 0.46s (± 0.80%) +0.00s (+ 0.44%) 0.45s 0.46s
Check Time 6.28s (± 0.40%) 6.26s (± 0.24%) -0.02s (- 0.38%) 6.23s 6.30s
Emit Time 2.04s (± 0.98%) 2.04s (± 0.55%) +0.00s (+ 0.10%) 2.02s 2.07s
Total Time 9.66s (± 0.42%) 9.65s (± 0.22%) -0.01s (- 0.13%) 9.61s 9.69s
Monaco - node (v14.15.1, x64)
Memory used 314,595k (± 0.01%) 314,595k (± 0.01%) -1k (- 0.00%) 314,517k 314,662k
Parse Time 1.56s (± 0.69%) 1.57s (± 0.61%) +0.01s (+ 0.64%) 1.56s 1.60s
Bind Time 0.63s (± 0.88%) 0.64s (± 1.07%) +0.00s (+ 0.63%) 0.63s 0.66s
Check Time 5.16s (± 0.26%) 5.18s (± 0.31%) +0.02s (+ 0.41%) 5.15s 5.23s
Emit Time 2.85s (± 0.54%) 2.88s (± 1.08%) +0.03s (+ 1.16%) 2.82s 2.96s
Total Time 10.20s (± 0.21%) 10.27s (± 0.41%) +0.06s (+ 0.64%) 10.19s 10.36s
TFS - node (v14.15.1, x64)
Memory used 279,323k (± 0.01%) 279,323k (± 0.01%) 0k ( 0.00%) 279,291k 279,363k
Parse Time 1.32s (± 1.18%) 1.32s (± 1.11%) -0.00s (- 0.23%) 1.30s 1.37s
Bind Time 0.59s (± 0.76%) 0.59s (± 0.81%) -0.00s (- 0.17%) 0.58s 0.60s
Check Time 5.07s (± 0.31%) 5.07s (± 0.29%) +0.00s (+ 0.10%) 5.03s 5.10s
Emit Time 3.05s (± 0.71%) 3.06s (± 1.15%) +0.02s (+ 0.52%) 2.98s 3.13s
Total Time 10.03s (± 0.30%) 10.05s (± 0.47%) +0.01s (+ 0.14%) 9.94s 10.14s
material-ui - node (v14.15.1, x64)
Memory used 430,701k (± 0.00%) 430,760k (± 0.00%) +59k (+ 0.01%) 430,726k 430,779k
Parse Time 1.88s (± 0.72%) 1.88s (± 0.48%) +0.00s (+ 0.11%) 1.86s 1.90s
Bind Time 0.53s (± 0.56%) 0.54s (± 1.28%) +0.01s (+ 1.33%) 0.52s 0.55s
Check Time 12.22s (± 0.57%) 12.21s (± 0.43%) -0.01s (- 0.09%) 12.13s 12.36s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.63s (± 0.52%) 14.62s (± 0.34%) -0.00s (- 0.02%) 14.56s 14.78s
xstate - node (v14.15.1, x64)
Memory used 504,464k (± 0.00%) 504,478k (± 0.01%) +14k (+ 0.00%) 504,423k 504,583k
Parse Time 2.63s (± 1.10%) 2.62s (± 0.45%) -0.01s (- 0.19%) 2.59s 2.64s
Bind Time 0.84s (± 0.69%) 0.84s (± 1.25%) -0.00s (- 0.36%) 0.83s 0.88s
Check Time 1.47s (± 0.42%) 1.47s (± 0.51%) +0.01s (+ 0.34%) 1.46s 1.49s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.01s (± 0.58%) 5.01s (± 0.37%) -0.01s (- 0.10%) 4.96s 5.03s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51439 10
Baseline main 10

TSServer

Comparison Report - main..51439
Metric main 51439 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,042ms (± 0.64%) 1,043ms (± 0.68%) +1ms (+ 0.12%) 1,035ms 1,064ms
Req 2 - geterr 2,541ms (± 0.75%) 2,542ms (± 0.74%) +1ms (+ 0.04%) 2,514ms 2,592ms
Req 3 - references 166ms (± 1.14%) 165ms (± 0.88%) -0ms (- 0.18%) 162ms 168ms
Req 4 - navto 137ms (± 1.11%) 137ms (± 0.41%) -0ms (- 0.15%) 136ms 138ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 59ms (± 2.94%) 60ms (± 2.98%) +1ms (+ 2.21%) 56ms 63ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,096ms (± 0.59%) 1,096ms (± 0.77%) -0ms (- 0.04%) 1,081ms 1,117ms
Req 2 - geterr 1,556ms (± 0.51%) 1,569ms (± 0.63%) +13ms (+ 0.83%) 1,550ms 1,590ms
Req 3 - references 168ms (± 0.58%) 169ms (± 0.86%) +1ms (+ 0.66%) 166ms 173ms
Req 4 - navto 150ms (± 0.58%) 149ms (± 0.50%) -1ms (- 0.60%) 148ms 151ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 54ms (± 3.67%) 54ms (± 3.24%) -1ms (- 1.29%) 51ms 60ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,500ms (± 0.56%) 1,504ms (± 0.46%) +5ms (+ 0.31%) 1,491ms 1,517ms
Req 2 - geterr 554ms (± 0.88%) 558ms (± 0.77%) +3ms (+ 0.61%) 548ms 566ms
Req 3 - references 59ms (± 2.68%) 60ms (± 2.60%) +1ms (+ 1.35%) 57ms 64ms
Req 4 - navto 196ms (± 1.02%) 196ms (± 0.96%) -0ms (- 0.10%) 192ms 200ms
Req 5 - completionInfo count 3,149 (± 0.00%) 3,149 (± 0.00%) 0 ( 0.00%) 3,149 3,149
Req 5 - completionInfo 212ms (± 0.87%) 212ms (± 1.10%) +0ms (+ 0.09%) 208ms 218ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,302ms (± 0.50%) 1,304ms (± 0.52%) +2ms (+ 0.13%) 1,282ms 1,315ms
Req 2 - geterr 3,167ms (± 0.64%) 3,185ms (± 0.72%) +18ms (+ 0.57%) 3,125ms 3,230ms
Req 3 - references 192ms (± 0.76%) 193ms (± 1.06%) +0ms (+ 0.16%) 188ms 196ms
Req 4 - navto 151ms (± 0.74%) 151ms (± 0.67%) +1ms (+ 0.33%) 149ms 153ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 61ms (± 2.39%) 62ms (± 6.64%) +1ms (+ 1.32%) 57ms 73ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,379ms (± 0.59%) 1,389ms (± 0.93%) +11ms (+ 0.77%) 1,355ms 1,411ms
Req 2 - geterr 2,068ms (± 0.46%) 2,072ms (± 0.37%) +4ms (+ 0.20%) 2,053ms 2,088ms
Req 3 - references 199ms (± 0.65%) 199ms (± 0.71%) 0ms ( 0.00%) 196ms 202ms
Req 4 - navto 165ms (± 1.08%) 165ms (± 0.90%) -0ms (- 0.12%) 162ms 169ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 58ms (± 2.25%) 58ms (± 3.28%) +1ms (+ 1.39%) 54ms 61ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,826ms (± 0.54%) 1,825ms (± 0.39%) -1ms (- 0.05%) 1,808ms 1,836ms
Req 2 - geterr 714ms (± 0.61%) 712ms (± 0.55%) -2ms (- 0.21%) 704ms 721ms
Req 3 - references 68ms (± 1.27%) 68ms (± 1.14%) -0ms (- 0.15%) 66ms 69ms
Req 4 - navto 198ms (± 0.84%) 198ms (± 0.51%) -1ms (- 0.45%) 195ms 199ms
Req 5 - completionInfo count 3,149 (± 0.00%) 3,149 (± 0.00%) 0 ( 0.00%) 3,149 3,149
Req 5 - completionInfo 255ms (± 0.92%) 252ms (± 0.65%) -3ms (- 1.26%) 248ms 256ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,443ms (± 0.43%) 1,454ms (± 0.52%) +12ms (+ 0.80%) 1,439ms 1,473ms
Req 2 - geterr 3,394ms (± 0.67%) 3,413ms (± 1.16%) +19ms (+ 0.56%) 3,365ms 3,546ms
Req 3 - references 206ms (± 0.74%) 206ms (± 0.57%) +1ms (+ 0.24%) 204ms 209ms
Req 4 - navto 161ms (± 0.77%) 162ms (± 0.90%) +1ms (+ 0.50%) 159ms 166ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 63ms (± 8.04%) 64ms (± 7.88%) +0ms (+ 0.47%) 57ms 73ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,524ms (± 0.39%) 1,530ms (± 0.69%) +6ms (+ 0.39%) 1,513ms 1,558ms
Req 2 - geterr 2,251ms (± 0.49%) 2,252ms (± 0.48%) +1ms (+ 0.04%) 2,234ms 2,278ms
Req 3 - references 212ms (± 1.06%) 214ms (± 1.29%) +2ms (+ 0.71%) 209ms 219ms
Req 4 - navto 174ms (± 0.79%) 174ms (± 0.74%) +0ms (+ 0.06%) 171ms 177ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 66ms (± 7.67%) 63ms (± 8.21%) 🟩-3ms (- 3.81%) 55ms 72ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,002ms (± 0.39%) 2,012ms (± 0.44%) +10ms (+ 0.51%) 1,987ms 2,031ms
Req 2 - geterr 740ms (± 0.45%) 737ms (± 0.39%) -2ms (- 0.31%) 731ms 747ms
Req 3 - references 72ms (± 1.33%) 72ms (± 1.49%) 0ms ( 0.00%) 69ms 74ms
Req 4 - navto 219ms (± 1.04%) 219ms (± 0.85%) -1ms (- 0.32%) 216ms 223ms
Req 5 - completionInfo count 3,149 (± 0.00%) 3,149 (± 0.00%) 0 ( 0.00%) 3,149 3,149
Req 5 - completionInfo 272ms (± 1.90%) 267ms (± 0.61%) -5ms (- 1.98%) 265ms 271ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51439 10
Baseline main 10

Startup

Comparison Report - main..51439
Metric main 51439 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 116.78ms (± 0.35%) 117.63ms (± 0.37%) +0.86ms (+ 0.73%) 115.57ms 122.65ms
tsserver-startup - node (v16.17.1, x64)
Execution time 197.02ms (± 0.31%) 198.82ms (± 0.37%) +1.79ms (+ 0.91%) 195.45ms 206.31ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 186.38ms (± 0.32%) 191.11ms (± 0.46%) +4.73ms (+ 2.54%) 185.79ms 199.32ms
typescript-startup - node (v16.17.1, x64)
Execution time 172.34ms (± 0.31%) 176.19ms (± 0.46%) +3.85ms (+ 2.23%) 171.91ms 183.84ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 51439 10
Baseline main 10

Developer Information:

Download Benchmark

@jakebailey jakebailey marked this pull request as ready for review November 9, 2022 22:49
@jakebailey jakebailey changed the title Remove ts.Map, ts.Set, associated types Remove ts.Map, ts.Set, ts.ESMap, associated types Nov 9, 2022
@jakebailey jakebailey changed the title Remove ts.Map, ts.Set, ts.ESMap, associated types Remove ts.Map, ts.Set, ts.ESMap, ts.Iterator, associated types Nov 9, 2022
@jakebailey jakebailey changed the title Remove ts.Map, ts.Set, ts.ESMap, ts.Iterator, associated types Remove ts.{Map,Set,ESMap,Iterator} and associated types Nov 9, 2022
@jakebailey jakebailey merged commit 9f64a3a into microsoft:main Nov 9, 2022
@jakebailey jakebailey deleted the remove-mapset branch November 9, 2022 23:06
@jakebailey jakebailey mentioned this pull request Nov 14, 2022
Merged
@DanielRosenwasser DanielRosenwasser mentioned this pull request Dec 8, 2022
Closed
@jakebailey jakebailey mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees

@jakebailey jakebailey

Labels
API Relates to the public API for TypeScript Author: Team Breaking Change Would introduce errors in existing code For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakebailey @typescript-bot @sheetalkamat