Undo accidental style changes from Map/Set PR #51529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
Uh, oops. Guess I screwed up fixing my screwup |
|
Okay, now it looks fine, per: https://github.com/microsoft/TypeScript/pull/51529/files?w=1 |
sheetalkamat
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point during my rebase of #51439, VS Code must have run the formatter on our code. I don't know how (it's disabled globally to avoid this happening), but I really did not intend to do this. It was also missed in review, probably because the PR was big and diffs got collapsed.
Revert the style changes, even the ones that are good.
(And this is why I want a formatter...)