Class inference from prototypes in JavaScript #5578
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vices Do not get the apparent type for 'getContextualType' in the services layer
Improve type guard consistiency
… --sourceRoot Note that --sourceRoot fails with crash
added missing check if file is specified
Encoding bug
Fixes use of combination of options sourceRoot and mapRoot with inlineSourceMap and inlineSources
…nCaseClause always check statements in case clause
…fig.json Since we dont support arbitary list of extensions to treat as .js, it becomes easier to simplify code based on the assumptions
…e function is void/any
ignore all trivia except singleline comments when processing triplesl…
Fix completion and quick info crash in type parameter in function in type alias
Extract source map generation logic out of the emitter.
…ntDecorators Various fixes for sourcemap and breakpoints of decorators
…edVoid do not report 'noImplicitReturns' error if inferred return type of th…
Do not emit names and name index mapping in source map
Sync the dom.generated.d.ts files from TSJS repo
Give more helpful error when trying to set default values on an interface.
# Conflicts: # src/compiler/binder.ts # src/compiler/checker.ts # src/harness/fourslash.ts
|
Closing in favor of #5876 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
func.prototype.memberfuncas an "inferred class"func's call signature into a construct signaturememberto theprototypeproperty offuncthis.memberin the body of an "inferred class" function implementation add amemberinstance property to the return type offunc's construct signatureprototypeproperty along with its instance membersImplementation details
module.exports,exports,this., orfunc.prototype.memberkindtoSignature(call vs construct) because it is no longer possible to distinguish them syntacticallyMerge incoming but wanted to get this posted