Skip to content

[Combobox] Fix binding to a value not in the list items. #4353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 2 commits into from
Nov 25, 2025
+12 −4
Merged

[Combobox] Fix binding to a value not in the list items. #4353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6ced5d
When getting the combobox content, the Value should be returned inste…
vnbaaij Nov 25, 2025
096c67b
Update verified file
vnbaaij Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions examples/Demo/Shared/Microsoft.FluentUI.AspNetCore.Components.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1794,6 +1794,14 @@
<member name="P:Microsoft.FluentUI.AspNetCore.Components.SelectColumn`1.SortBy">
<inheritdoc />
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.SelectColumn`1.Comparer">
<summary>
Gets or sets the equality comparer used to determine whether two grid items are equal.
</summary>
<remarks>If not set, the default equality comparer for <typeparamref name="TGridItem"/> is used.
Setting this property allows customization of how grid items are compared for equality, which can affect
operations such as selection, filtering, or updating items in the grid.</remarks>
</member>
<member name="M:Microsoft.FluentUI.AspNetCore.Components.SelectColumn`1.ClearSelection">
<summary>
Allows to clear the selection.
Expand Down
4 changes: 2 additions & 2 deletions src/Core/Components/List/FluentCombobox.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public override async Task SetParametersAsync(ParameterView parameters)
protected override async Task ChangeHandlerAsync(ChangeEventArgs e)
{

if (e.Value is not null && Items is not null)
if (e.Value is not null && Items is not null )
{
var value = e.Value.ToString();
var item = Items.FirstOrDefault(i => GetOptionText(i) == value);
Expand Down Expand Up @@ -171,7 +171,7 @@ protected override async Task ChangeHandlerAsync(ChangeEventArgs e)
}
else
{
return null;
return Value;
}
}

Expand Down
4 changes: 2 additions & 2 deletions tests/Core/List/FluentComboboxTests.FluentCombobox_ClearSelection.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

<style>#myComponent::part(listbox) { z-index: 9995 }</style>
<fluent-combobox id="xxx" position="below" blazor:oncomboboxchange="1" blazor:oncontrolinput="2" blazor:elementreference="">
<fluent-combobox id="xxx" current-value="" position="below" blazor:oncomboboxchange="1" blazor:oncontrolinput="2" blazor:elementreference="">
<fluent-option id="xxx" value="Contoso" blazor:onclick="3" aria-selected="false" blazor:elementreference="">Contoso</fluent-option>
</fluent-combobox>
</fluent-combobox>
Loading