This repository was archived by the owner on Jun 10, 2022. It is now read-only.
Transform updates not propagating for attachments when using subscription 'transform'#740
Closed
David032 wants to merge 2 commits intomicrosoft:masterfrom
David032:develop/bonkDungeon
Closed
Transform updates not propagating for attachments when using subscription 'transform'#740David032 wants to merge 2 commits intomicrosoft:masterfrom David032:develop/bonkDungeon
David032 wants to merge 2 commits intomicrosoft:masterfrom
David032:develop/bonkDungeon
Conversation
Contributor
|
Pull request #745 addresses this fix from both client -> app and app -> client. Closing in favor of that fix once it is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was flagged in the MRE-SDK discord here that transform updates do not propagate to attachments when using the subscription 'transform'
This could be intentional, I don't know? But if it's not, this fix & the attached issue #739 corrects it