This repository was archived by the owner on Jun 10, 2022. It is now read-only.
Fix for transform subscriptions when actor is an attachment #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuMS
suggested changes
Mar 25, 2021
Contributor
tombuMS
left a comment
tombuMS
left a comment
There was a problem hiding this comment.
Some protection regarding potentially undefined syncActor needs to be added. See comments
| const syncActor = session.actorSet.get(message.payload.actorId); | ||
| if (syncActor && ((client.authoritative && !syncActor.grabbedBy) | ||
| || (syncActor.grabbedBy === client.id))) { | ||
| const attachment = syncActor.initialization.message.payload.actor.attachment; |
Contributor
There was a problem hiding this comment.
It is possible for syncActor to be undefined here which will cause this to throw an exception. Getting the attachment will need to be moved into the if block below it where syncActor will already be tested for undefined. Alternatively you can do optional chaining on the syncActor like:
const attachment = syncActor?.initialization.message.payload.actor.attachment;
Contributor
Author
There was a problem hiding this comment.
Fixed. See latest commit.
| message: Message<Payloads.ActorUpdate> | ||
| ) => { | ||
| const syncActor = session.actorSet.get(message.payload.actor.id); | ||
| const attachment = syncActor.initialization.message.payload.actor.attachment; |
Contributor
There was a problem hiding this comment.
See same comment above about syncActyor being undefined.
Contributor
Author
There was a problem hiding this comment.
Fixed. See latest commit.
tombuMS
approved these changes
Mar 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows transform subscriptions to pass to the app when actor is an attachment.
Issue #739
This PR is similar to #740 but for the correct branch (red).