Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(atenlib): add ops(cross_entropy_loss) #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(atenlib): add ops(cross_entropy_loss) #444
Changes from all commits
dafe80a
2ca53e2
f15ec49
3437ab4
aa50a53
02c6a39
810a7f7
23a2bb3
5f69ad5
2c61513
601b81f
e6dd73f
6a4228f
a617691
50cabda
96d0a02
4f32ab8
0eb5c73
365e58d
a8a8d5d
818d75c
253ee00
ea18c3f
785f34a
b9a94c5
00a606f
ecc6077
b11d894
f3baa71
164884c
dc0bf6e
b70c4d5
b610562
d4edfe8
6be5eb3
58ba823
94a0f5c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a comment on why trace only is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible to combine the functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/microsoft/onnx-script/pull/555/files