feat(atenlib): add ops(cross_entropy_loss) #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #444 +/- ##
==========================================
- Coverage 72.52% 72.43% -0.10%
==========================================
Files 109 109
Lines 10626 10645 +19
Branches 1096 1100 +4
==========================================
+ Hits 7707 7711 +4
- Misses 2612 2627 +15
Partials 307 307
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Closed
fatcat-z
reviewed
Feb 17, 2023
fatcat-z
reviewed
Feb 17, 2023
fatcat-z
reviewed
Feb 17, 2023
onnxscript/tests/function_libs/torch_aten/ops_correctness_test.py
Outdated
Show resolved
Hide resolved
justinchuby
reviewed
Feb 17, 2023
justinchuby
reviewed
Feb 17, 2023
justinchuby
reviewed
Feb 17, 2023
justinchuby
reviewed
Feb 17, 2023
justinchuby
reviewed
Feb 17, 2023
xiaowuhu
changed the title
justinchuby
reviewed
Feb 20, 2023
onnxscript/tests/function_libs/torch_aten/ops_correctness_test.py
Outdated
Show resolved
Hide resolved
fatcat-z
reviewed
Feb 22, 2023
onnxscript/tests/function_libs/torch_aten/ops_correctness_test.py
Outdated
Show resolved
Hide resolved
fatcat-z
reviewed
Feb 22, 2023
onnxscript/tests/function_libs/torch_aten/ops_correctness_test.py
Outdated
Show resolved
Hide resolved
justinchuby
reviewed
Feb 24, 2023
justinchuby
reviewed
Feb 24, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fatcat-z
reviewed
Feb 28, 2023
justinchuby
reviewed
Mar 4, 2023
| raise NotImplementedError() | ||
|
|
||
|
|
||
| @torch_op("aten::cross_entropy_loss", trace_only=True) |
Collaborator
There was a problem hiding this comment.
I would add a comment on why trace only is needed
Collaborator
There was a problem hiding this comment.
Possible to combine the functions?
Collaborator
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.