Define the EXPERIMENTAL_PREFER_TRACING flag and the traceable option | feat(torchlib) #1176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <[email protected]> [ghstack-poisoned]
This was referenced Nov 22, 2023
justinchuby
changed the title
justinchuby
changed the title
justinchuby
added
the
module: torchlib
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
==========================================
+ Coverage 78.67% 78.71% +0.03%
==========================================
Files 118 118
Lines 15334 15348 +14
Branches 2392 2394 +2
==========================================
+ Hits 12064 12081 +17
+ Misses 2876 2873 -3
Partials 394 394 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 22, 2023
…g and the traceable option | feat(torchlib)" As an effort described in #1095, this PR - adds an experimental `TORCHLIB_EXPERIMENTAL_PREFER_TRACING` flag to allow the tracer to trace a function when possible. - defined the `traceable` option in the torch_op decorator to mark a function as `traceable`. [ghstack-poisoned]
…ble option | feat(torchlib)" As an effort described in #1095, this PR - adds an experimental `TORCHLIB_EXPERIMENTAL_PREFER_TRACING` flag to allow the tracer to trace a function when possible. - defined the `traceable` option in the torch_op decorator to mark a function as `traceable`. [ghstack-poisoned]
BowenBao
reviewed
Nov 22, 2023
| @@ -112,6 +113,7 @@ def torch_op( | |||
| private: Whether the function is private (not directly exposed). It should | |||
| be true for all functions with names starting with "_". | |||
| complex: Whether the function expects complex-valued inputs. | |||
| traceable: Whether the function can be traced. | |||
There was a problem hiding this comment.
I don't understand this comment. Could you elaborate?
There was a problem hiding this comment.
A function is traceable if it can both be scripted and traced and produce the same result for a given input. Does that sound reasonable? I will add this to the docstring if it does.
There was a problem hiding this comment.
- A function can be tagged with traceable if its if branches (if any) can be statically evaluated.
- A function should be tagged with traceable if it contains if branches and/or CastLike nodes so that they can be evaluated away with the
EXPERIMENTAL_PREFER_TRACINGon. - A function without if branches or CastLike nodes should not be tagged with traceable because inlining will do the same thing.
- A function with
@graphdefined for aScanop is not traceable yet.
There was a problem hiding this comment.
Is there any chance one could wrongly tag a function traceable, and create a bug?
There was a problem hiding this comment.
There is a chance. We should be able to catch them in the op info tests.
…g and the traceable option | feat(torchlib)" As an effort described in #1095, this PR - adds an experimental `TORCHLIB_EXPERIMENTAL_PREFER_TRACING` flag to allow the tracer to trace a function when possible. - defined the `traceable` option in the torch_op decorator to mark a function as `traceable`. [ghstack-poisoned]
…ble option | feat(torchlib)" As an effort described in #1095, this PR - adds an experimental `TORCHLIB_EXPERIMENTAL_PREFER_TRACING` flag to allow the tracer to trace a function when possible. - defined the `traceable` option in the torch_op decorator to mark a function as `traceable`. [ghstack-poisoned]
…g and the traceable option | feat(torchlib)" As an effort described in #1095, this PR - adds an experimental `TORCHLIB_EXPERIMENTAL_PREFER_TRACING` flag to allow the tracer to trace a function when possible. - defined the `traceable` option in the torch_op decorator to mark a function as `traceable`. [ghstack-poisoned]
…ble option | feat(torchlib)" As an effort described in #1095, this PR - adds an experimental `TORCHLIB_EXPERIMENTAL_PREFER_TRACING` flag to allow the tracer to trace a function when possible. - defined the `traceable` option in the torch_op decorator to mark a function as `traceable`. [ghstack-poisoned]
…g and the traceable option | feat(torchlib)" As an effort described in #1095, this PR - adds an experimental `TORCHLIB_EXPERIMENTAL_PREFER_TRACING` flag to allow the tracer to trace a function when possible. - defined the `traceable` option in the torch_op decorator to mark a function as `traceable`. [ghstack-poisoned]
…ble option | feat(torchlib)" As an effort described in #1095, this PR - adds an experimental `TORCHLIB_EXPERIMENTAL_PREFER_TRACING` flag to allow the tracer to trace a function when possible. - defined the `traceable` option in the torch_op decorator to mark a function as `traceable`. [ghstack-poisoned]
…g and the traceable option | feat(torchlib)" As an effort described in #1095, this PR - adds an experimental `TORCHLIB_EXPERIMENTAL_PREFER_TRACING` flag to allow the tracer to trace a function when possible. - defined the `traceable` option in the torch_op decorator to mark a function as `traceable`. [ghstack-poisoned]
…ble option | feat(torchlib)" As an effort described in #1095, this PR - adds an experimental `TORCHLIB_EXPERIMENTAL_PREFER_TRACING` flag to allow the tracer to trace a function when possible. - defined the `traceable` option in the torch_op decorator to mark a function as `traceable`. [ghstack-poisoned]
…g and the traceable option | feat(torchlib)" As an effort described in #1095, this PR - adds an experimental `TORCHLIB_EXPERIMENTAL_PREFER_TRACING` flag to allow the tracer to trace a function when possible. - defined the `traceable` option in the torch_op decorator to mark a function as `traceable`. [ghstack-poisoned]
…ble option | feat(torchlib)" As an effort described in #1095, this PR - adds an experimental `TORCHLIB_EXPERIMENTAL_PREFER_TRACING` flag to allow the tracer to trace a function when possible. - defined the `traceable` option in the torch_op decorator to mark a function as `traceable`. [ghstack-poisoned]
xiaowuhu
pushed a commit
that referenced
this pull request
Nov 27, 2023
…t(torchlib) (#1180) Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #1178 * #1177 * #1176 * __->__ #1180 ### Changes - Create env to test with TORCHLIB_EXPERIMENTAL_PREFER_TRACING on - Test with Python 3.11 as well - Fixes #1061 - Fix aten::any.dims and aten::all.dims
…g and the traceable option | feat(torchlib)" As an effort described in #1095, this PR - adds an experimental `TORCHLIB_EXPERIMENTAL_PREFER_TRACING` flag to allow the tracer to trace a function when possible. - defined the `traceable` option in the torch_op decorator to mark a function as `traceable`. [ghstack-poisoned]
…ble option | feat(torchlib)" As an effort described in #1095, this PR - adds an experimental `TORCHLIB_EXPERIMENTAL_PREFER_TRACING` flag to allow the tracer to trace a function when possible. - defined the `traceable` option in the torch_op decorator to mark a function as `traceable`. [ghstack-poisoned]
titaiwangms
approved these changes
Nov 28, 2023
|
Will merge now. LMK if I should create follow ups |
justinchuby
added a commit
that referenced
this pull request
Nov 28, 2023
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #1178 * __->__ #1177 * #1176 As an effort described in #1095, this PR marks functions with if branches as traceable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As an effort described in #1095, this PR
TORCHLIB_EXPERIMENTAL_PREFER_TRACINGflag to allow the tracer to trace a function when possible.traceableoption in the torch_op decorator to mark a function astraceable.