Skip to content

[Experimental] Convert CastLike to Cast when dtype is available | feat(torchlib) #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (ccfe90d) 78.53% compared to head (0d0c11e) 78.48%.

Files Patch % Lines
...nxscript/function_libs/torch_lib/graph_building.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           gh/justinchuby/47/base    #1179      +/-   ##
==========================================================
- Coverage                   78.53%   78.48%   -0.06%     
==========================================================
  Files                         118      118              
  Lines                       15339    15344       +5     
  Branches                     2396     2397       +1     
==========================================================
- Hits                        12046    12042       -4     
- Misses                       2904     2914      +10     
+ Partials                      389      388       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

justinchuby added a commit that referenced this pull request Nov 22, 2023
ghstack-source-id: 6568969
Pull Request resolved: #1179

Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Nov 22, 2023
@justinchuby justinchuby changed the title Convert CastLike to Cast when dtype is available | feat(torchlib) [Experimental] Convert CastLike to Cast when dtype is available | feat(torchlib) Nov 22, 2023
justinchuby added a commit that referenced this pull request Nov 22, 2023
ghstack-source-id: 9edcef0
Pull Request resolved: #1179

Signed-off-by: Justin Chu <[email protected]>
justinchuby added a commit that referenced this pull request Nov 22, 2023
ghstack-source-id: d4b13d6
Pull Request resolved: #1179

Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby added the change base before merge Remember to change the merge base to main when the PR is ready to merge label Nov 22, 2023
justinchuby added a commit that referenced this pull request Nov 22, 2023
ghstack-source-id: 09822b6
Pull Request resolved: #1179

Signed-off-by: Justin Chu <[email protected]>
justinchuby added a commit that referenced this pull request Nov 22, 2023
ghstack-source-id: 939bf58
Pull Request resolved: #1179

Signed-off-by: Justin Chu <[email protected]>
Copy link

Test Results

         24 files  ±    0         24 suites  ±0   1h 38m 34s ⏱️ - 16m 35s
  11 194 tests ±    0    8 336 ✔️ +17      2 790 💤 +6       68  -   23 
268 310 runs   - 264  60 407 ✔️  -   3  205 793 💤 ±0  2 110  - 261 

For more details on these failures, see this check.

Results for commit 0d0c11e. ± Comparison against base commit ccfe90d.

@justinchuby justinchuby deleted the gh/justinchuby/47/head branch May 5, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change base before merge Remember to change the merge base to main when the PR is ready to merge module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant