Skip to content

Add support for aten:index op when index is boolean | feat(torchlib) #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 5, 2024

Conversation

fatcat-z
Copy link
Contributor

@fatcat-z fatcat-z commented Mar 4, 2024

Implement index.Tensor(Tensor self, Tensor?[] indices) -> Tensor when indices is boolean.

Fix #1141

@fatcat-z fatcat-z requested review from justinchuby and xiaowuhu March 4, 2024 10:53
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.99%. Comparing base (ce3eb4a) to head (e27ffed).
Report is 11 commits behind head on main.

Files Patch % Lines
...ript/tests/function_libs/torch_lib/extra_opinfo.py 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1285      +/-   ##
==========================================
+ Coverage   78.68%   78.99%   +0.30%     
==========================================
  Files         119      119              
  Lines       15762    15816      +54     
  Branches     2486     2499      +13     
==========================================
+ Hits        12403    12494      +91     
+ Misses       2950     2909      -41     
- Partials      409      413       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@justinchuby justinchuby merged commit f9f2fa2 into microsoft:main Mar 5, 2024
justinchuby added a commit that referenced this pull request Mar 19, 2024
…rchlib)" (#1307)

Reverting because this causes the dispatcher in PyTorch to choose the
wrong overload. Reverts #1285
@fatcat-z fatcat-z deleted the add_index_bool branch March 25, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[torchlib] aten::index on boolean indicies
2 participants