Skip to content

Revert "Add support for aten:index op when index is boolean | feat(torchlib)" #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Mar 19, 2024

Reverting because this causes the dispatcher in PyTorch to choose the wrong overload. Reverts #1285

Copy link

github-actions bot commented Mar 19, 2024

Test Results

     24 files  ±  0      24 suites  ±0   1h 33m 47s ⏱️ - 6m 5s
 11 428 tests  -  11   8 460 ✅  -  10    2 967 💤 ±0  1 ❌  - 1 
258 265 runs   - 165  58 959 ✅  - 164  199 305 💤 ±0  1 ❌  - 1 

For more details on these failures, see this check.

Results for commit 4f5a633. ± Comparison against base commit 6380593.

This pull request removes 258 and adds 247 tests. Note that renamed tests count towards both.
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_109_aten_index_bool
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_110_aten_index_put_bool
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_111_aten_index_put
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_112_aten_index_select
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_113_aten_isclose
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_114_aten_isfinite
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_115_aten_isinf
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_116_aten_isnan
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_117_aten_isneginf
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_118_aten_isposinf
…
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_109_aten_index_put_bool
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_110_aten_index_put
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_111_aten_index_select
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_112_aten_isclose
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_113_aten_isfinite
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_114_aten_isinf
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_115_aten_isnan
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_116_aten_isneginf
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_117_aten_isposinf
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_118_aten_lift_fresh_copy
…

♻️ This comment has been updated with latest results.

@justinchuby justinchuby merged commit ad6faf2 into main Mar 19, 2024
@justinchuby justinchuby deleted the revert-1285-add_index_bool branch March 19, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants