Skip to content

feat(atenlib): establish the aten-lib directory #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 30, 2022
Merged

feat(atenlib): establish the aten-lib directory #202

merged 11 commits into from
Nov 30, 2022

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Nov 22, 2022 •
edited
Loading

justinchuby added a commit that referenced this pull request Nov 22, 2022
@justinchuby
feat(atenlib): establish the aten-lib directory
f318ba0 
ghstack-source-id: a71e59c
Pull Request resolved: #202
@codecov
Copy link

codecov bot commented Nov 22, 2022 •
edited
Loading

Codecov Report

Merging #202 (a56836f) into main (2ba8548) will decrease coverage by 0.27%.
The diff coverage is n/a.

❗ Current head a56836f differs from pull request most recent head 9aa120d. Consider uploading reports for the commit 9aa120d to get more accurate results

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   75.50%   75.23%   -0.28%     
==========================================
  Files          89       89              
  Lines        7198     7219      +21     
==========================================
- Hits         5435     5431       -4     
- Misses       1763     1788      +25
Impacted Files Coverage Δ
onnxscript/analysis.py 90.13% <0.00%> (-3.95%) ⬇️
onnxscript/values.py 84.78% <0.00%> (-2.65%) ⬇️
onnxscript/onnx_opset/_impl/opset10.py 63.33% <0.00%> (-1.79%) ⬇️
onnxscript/onnx_opset/_impl/opset11.py 58.30% <0.00%> (-0.53%) ⬇️
onnxscript/test/analysis_test.py 58.41% <0.00%> (-0.41%) ⬇️
onnxscript/converter.py 91.06% <0.00%> (-0.30%) ⬇️
onnxscript/sourceinfo.py
onnxscript/debuginfo.py 70.00% <0.00%> (ø)
onnxscript/main.py 87.27% <0.00%> (+3.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@justinchuby justinchuby mentioned this pull request Nov 22, 2022
Closed
justinchuby added a commit that referenced this pull request Nov 22, 2022
@justinchuby
feat(atenlib): establish the aten-lib directory
9c46597 
ghstack-source-id: 76cbf38
Pull Request resolved: #202
@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Nov 23, 2022
@justinchuby justinchuby mentioned this pull request Nov 23, 2022
Closed
@justinchuby justinchuby mentioned this pull request Nov 29, 2022
Merged
@justinchuby justinchuby requested a review from fatcat-z November 29, 2022 04:12
@justinchuby justinchuby mentioned this pull request Nov 30, 2022
Merged
@justinchuby
Copy link
Collaborator Author

@fatcat-z please approve if it looks good. thanks!

fatcat-z
fatcat-z reviewed Nov 30, 2022
View reviewed changes
onnxscript/function_libs/torch_aten/__init__.py

The modules are named after the torch module names for grouping:

- core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Next time, let's sort them in alphabetical order.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified the list

fatcat-z
fatcat-z approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@justinchuby justinchuby changed the base branch from gh/justinchuby/1/base to main November 30, 2022 16:30
@justinchuby justinchuby merged commit b5b2875 into main Nov 30, 2022
@justinchuby justinchuby deleted the gh/justinchuby/1/head branch November 30, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatcat-z fatcat-z fatcat-z approved these changes

Assignees
No one assigned
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinchuby @fatcat-z