Skip to content

feat(atenlib): generate all aten signatures #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Dec 7, 2022
Merged

feat(atenlib): generate all aten signatures #223

merged 45 commits into from
Dec 7, 2022

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Nov 30, 2022 •
edited
Loading

@justinchuby
feat(atenlib): establish the aten-lib directory
2c8ee88 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): establish the aten-lib dire…
40af0b4 
…ctory"

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): establish the aten-lib directory"
ee554d7 
[ghstack-poisoned]
@justinchuby
feat(atenlib): Create sample functions and tests
fa8ce18 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): Create sample functions and…
6d426b5 
… tests with OpInfo"

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): Create sample functions and tests with OpInfo"
bb9fbee 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): create tests with OpInfo"
0aed28e 
[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): create tests with OpInfo"
91aa327 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): create tests with OpInfo"
00a081b 
[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): create tests with OpInfo"
fce8072 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): create tests with OpInfo"
af56008 
[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): create tests with OpInfo"
8c0b370 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): create tests with OpInfo"
bfeaefc 
[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): create tests with OpInfo"
8dc3d15 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): create tests with OpInfo"
46aa719 
[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): create tests with OpInfo"
d87f309 
[ghstack-poisoned]
@justinchuby
feat: aten function signature generator
afa50e3 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): aten function signature gen…
1b2674d 
…erator"

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): aten function signature generator"
1861734 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): aten function signature gen…
64810de 
…erator"

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): aten function signature generator"
421e9e4 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): aten function signature gen…
c566e24 
…erator"

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): aten function signature generator"
15ecd59 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): aten function signature gen…
2ab2fc3 
…erator"

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): aten function signature generator"
91fb612 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): aten function signature gen…
d49a69d 
…erator"

[ghstack-poisoned]
@justinchuby
feat(atenlib): generate all aten signatures
979ace1 
[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): aten function signature generator"
c7940b2 
[ghstack-poisoned]
This was referenced Nov 30, 2022
Merged
Merged
@justinchuby
Copy link
Collaborator Author

Error cases

  1. tensor list
def aten_unflatten_dense_tensors(flat: TensorType, tensors: TensorType[...]) -> TensorType:
    # unflatten_dense_tensors(Tensor flat, Tensor[] tensors) -> Tensor[]

    raise NotImplementedError()

@fatcat-z
Copy link
Contributor

fatcat-z commented Dec 1, 2022

The generator is designed to be one time to get us started. Thoughts?

I'd like to keep the code for the generator in the repo, to see if we can update it to regenerate some functions caused by ONNX improvement.

@justinchuby
Copy link
Collaborator Author

justinchuby commented Dec 1, 2022 •
edited
Loading

Yeah the code will be in the repo. Which is the previous PR in the stack #212

@justinchuby justinchuby mentioned this pull request Dec 5, 2022
Merged
@justinchuby justinchuby mentioned this pull request Dec 6, 2022
Merged
justinchuby added a commit that referenced this pull request Dec 6, 2022
@justinchuby
feat(atenlib): typing module (#233)
af136f4 
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #235
* #208
* #223
* #212
* __->__ #233
@justinchuby
Copy link
Collaborator Author

@fatcat-z PTAL

fatcat-z
fatcat-z approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

justinchuby added a commit that referenced this pull request Dec 7, 2022
@justinchuby
feat(atenlib): aten function signature generator (#212)
1d09990 
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #235
* #223
* __->__ #212
@justinchuby justinchuby changed the base branch from gh/justinchuby/5/base to main December 7, 2022 18:20
@justinchuby justinchuby merged commit c9b3ac6 into main Dec 7, 2022
@justinchuby justinchuby deleted the gh/justinchuby/5/head branch December 7, 2022 18:56
@justinchuby justinchuby mentioned this pull request Apr 7, 2023
Closed
Indie365 pushed a commit to Indie365/onnxscript that referenced this pull request Oct 26, 2023
@justinchuby
feat(atenlib): generate all aten signatures
6ad388b 
ghstack-source-id: 9d55062
Pull Request resolved: microsoft/onnxscript#223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramalingam gramalingam gramalingam left review comments

@fatcat-z fatcat-z fatcat-z approved these changes

@xiaowuhu xiaowuhu Awaiting requested review from xiaowuhu

Assignees
No one assigned
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinchuby @fatcat-z @gramalingam