feat(atenlib): add, sub, mul #235

justinchuby · 2022-12-06T04:07:14Z

Stack from ghstack (oldest at bottom):

-> feat(atenlib): add, sub, mul #235

[ghstack-poisoned]

…ctory" [ghstack-poisoned]

[ghstack-poisoned]

… tests with OpInfo" [ghstack-poisoned]

[ghstack-poisoned]

ghstack-source-id: 9b83578 Pull Request resolved: #235

justinchuby · 2022-12-06T04:10:49Z

onnxscript/function_libs/torch_aten/ops/core.py

+    return op.Mul(self, other)
+
+
+def aten_mul_bool(self: TensorType, other: TensorType) -> TensorType:


Need to test this as well

codecov · 2022-12-06T04:13:39Z

Codecov Report

Merging #235 (1184f6b) into main (c9b3ac6) will increase coverage by 0.04%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   71.65%   71.69%   +0.04%     
==========================================
  Files          93       93              
  Lines        8827     8833       +6     
==========================================
+ Hits         6325     6333       +8     
+ Misses       2502     2500       -2

Impacted Files	Coverage Δ
...t/function_libs/torch_aten/ops_correctness_test.py	`93.33% <ø> (ø)`
onnxscript/function_libs/torch_aten/ops/core.py	`50.73% <92.30%> (+0.40%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-advanced-security

lintrunner found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

onnxscript/function_libs/torch_aten/ops/core.py

[ghstack-poisoned]

ghstack-source-id: 89663f7 Pull Request resolved: #235

[ghstack-poisoned]

ghstack-source-id: f80f02b Pull Request resolved: #235

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #235 * #208 * #223 * #212 * __->__ #233

gramalingam · 2022-12-06T20:48:25Z

onnxscript/function_libs/torch_aten/ops/core.py

+    return op.Mul(self, other)
+
+
+def aten_mul_bool(self: BOOL, other: BOOL) -> BOOL:


BOOL[...] instead of BOOL ? Unless the type-annotation-design is going to change the meaning of BOOL, which is currently a tensor of rank-0

yeah but mypy complains about BOOL[...]

I’ll see if I can turn it off

Couldn't make it to work. I will leave it as is for now as update when things fit together. Currently the types for the ops are also BOOL etc. I think?

gramalingam · 2022-12-06T20:52:57Z

onnxscript/test/function_libs/torch_aten/ops_correctness_test.py

@@ -157,14 +157,19 @@ def wrapped(fn):

 # Ops to be tested for numerical consistency between onnx and pytorch
 OPINFO_FUNCTION_MAPPING = {
+    "add": core_ops.aten_add,


For my own knowledge: what is core_ops a reference to? I see core.py above.

Oh, I see it's just an alias for the same

fatcat-z

LGTM, thanks!

[ghstack-poisoned]

ghstack-source-id: f3fc07a Pull Request resolved: #235

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #235 * #223 * __->__ #212

[ghstack-poisoned]

ghstack-source-id: ac01a5b Pull Request resolved: #235

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #235 * __->__ #223

justinchuby added 30 commits November 22, 2022 17:48

feat(atenlib): establish the aten-lib directory

2c8ee88

[ghstack-poisoned]

Update base for Update on "feat(atenlib): establish the aten-lib dire…

40af0b4

…ctory" [ghstack-poisoned]

Update on "feat(atenlib): establish the aten-lib directory"

ee554d7

[ghstack-poisoned]

feat(atenlib): Create sample functions and tests

fa8ce18

[ghstack-poisoned]

Update base for Update on "feat(atenlib): Create sample functions and…

6d426b5

… tests with OpInfo" [ghstack-poisoned]

Update on "feat(atenlib): Create sample functions and tests with OpInfo"

bb9fbee

[ghstack-poisoned]

Update base for Update on "feat(atenlib): create tests with OpInfo"

0aed28e

[ghstack-poisoned]

Update on "feat(atenlib): create tests with OpInfo"

91aa327

[ghstack-poisoned]

Update base for Update on "feat(atenlib): create tests with OpInfo"

00a081b

[ghstack-poisoned]

Update on "feat(atenlib): create tests with OpInfo"

fce8072

[ghstack-poisoned]

Update base for Update on "feat(atenlib): create tests with OpInfo"

af56008

[ghstack-poisoned]

Update on "feat(atenlib): create tests with OpInfo"

8c0b370

[ghstack-poisoned]

Update base for Update on "feat(atenlib): create tests with OpInfo"

bfeaefc

[ghstack-poisoned]

Update on "feat(atenlib): create tests with OpInfo"

8dc3d15

[ghstack-poisoned]

Update base for Update on "feat(atenlib): create tests with OpInfo"

46aa719

[ghstack-poisoned]

Update on "feat(atenlib): create tests with OpInfo"

d87f309

[ghstack-poisoned]

Update base for Update on "feat(atenlib): create tests with OpInfo"

f7555e5

[ghstack-poisoned]

Update on "feat(atenlib): create tests with OpInfo"

c80ad0e

[ghstack-poisoned]

Update base for Update on "feat(atenlib): create tests with OpInfo"

01ac14f

[ghstack-poisoned]

Update on "feat(atenlib): create tests with OpInfo"

b730aa9

[ghstack-poisoned]

Update base for Update on "feat(atenlib): create tests with OpInfo"

1d57934

[ghstack-poisoned]

Update on "feat(atenlib): create tests with OpInfo"

407da68

[ghstack-poisoned]

Update base for Update on "feat(atenlib): create tests with OpInfo"

2d1e9aa

[ghstack-poisoned]

Update on "feat(atenlib): create tests with OpInfo"

4c3e9c2

[ghstack-poisoned]

Update base for Update on "feat(atenlib): create tests with OpInfo"

cede59b

[ghstack-poisoned]

Update on "feat(atenlib): create tests with OpInfo"

98bd90c

[ghstack-poisoned]

Update base for Update on "feat(atenlib): create tests with OpInfo"

b7144a6

[ghstack-poisoned]

Update on "feat(atenlib): create tests with OpInfo"

49fc7f1

[ghstack-poisoned]

Update base for Update on "feat(atenlib): create tests with OpInfo"

891fbd1

[ghstack-poisoned]

Update on "feat(atenlib): create tests with OpInfo"

63d4775

[ghstack-poisoned]

justinchuby added a commit that referenced this pull request Dec 6, 2022

feat(atenlib): add, sub, mul

9e8f9ad

ghstack-source-id: 9b83578 Pull Request resolved: #235

justinchuby added the module: torchlib Related to the torch/aten function lib in development label Dec 6, 2022

justinchuby commented Dec 6, 2022

View reviewed changes

github-advanced-security bot found potential problems Dec 6, 2022

View reviewed changes

justinchuby commented Dec 6, 2022

View reviewed changes

onnxscript/function_libs/torch_aten/ops/core.py Outdated Show resolved Hide resolved

justinchuby added 2 commits December 6, 2022 16:48

Update base for Update on "feat(atenlib): add, sub, mul"

89e67ac

[ghstack-poisoned]

Update on "feat(atenlib): add, sub, mul"

6b5c50b

[ghstack-poisoned]

justinchuby added a commit that referenced this pull request Dec 6, 2022

feat(atenlib): add, sub, mul

4f2ab7d

ghstack-source-id: 89663f7 Pull Request resolved: #235

justinchuby added 2 commits December 6, 2022 18:14

Update base for Update on "feat(atenlib): add, sub, mul"

e1ba56e

[ghstack-poisoned]

Update on "feat(atenlib): add, sub, mul"

3f35a2c

[ghstack-poisoned]

justinchuby added a commit that referenced this pull request Dec 6, 2022

feat(atenlib): add, sub, mul

f38ef94

ghstack-source-id: f80f02b Pull Request resolved: #235

justinchuby added a commit that referenced this pull request Dec 6, 2022

feat(atenlib): typing module (#233)

af136f4

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #235 * #208 * #223 * #212 * __->__ #233

gramalingam reviewed Dec 6, 2022

View reviewed changes

fatcat-z approved these changes Dec 7, 2022

View reviewed changes

justinchuby added 2 commits December 7, 2022 18:11

Update base for Update on "feat(atenlib): add, sub, mul"

fa9dde3

[ghstack-poisoned]

Update on "feat(atenlib): add, sub, mul"

6c1baf4

[ghstack-poisoned]

justinchuby added a commit that referenced this pull request Dec 7, 2022

feat(atenlib): add, sub, mul

9d963ab

ghstack-source-id: f3fc07a Pull Request resolved: #235

justinchuby added a commit that referenced this pull request Dec 7, 2022

feat(atenlib): aten function signature generator (#212)

1d09990

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #235 * #223 * __->__ #212

justinchuby changed the base branch from gh/justinchuby/7/base to main December 7, 2022 18:24

justinchuby added 2 commits December 7, 2022 18:48

Update base for Update on "feat(atenlib): add, sub, mul"

c6b2cc4

[ghstack-poisoned]

Update on "feat(atenlib): add, sub, mul"

0d13e27

[ghstack-poisoned]

justinchuby added a commit that referenced this pull request Dec 7, 2022

feat(atenlib): add, sub, mul

92aac91

ghstack-source-id: ac01a5b Pull Request resolved: #235

justinchuby added a commit that referenced this pull request Dec 7, 2022

feat(atenlib): generate all aten signatures (#223)

c9b3ac6

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #235 * __->__ #223

Merge branch 'main' into gh/justinchuby/7/head

1184f6b

gramalingam approved these changes Dec 7, 2022

View reviewed changes

justinchuby merged commit f802167 into main Dec 7, 2022

justinchuby deleted the gh/justinchuby/7/head branch December 7, 2022 19:11

justinchuby mentioned this pull request Dec 15, 2022

ATen ops list #258

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(atenlib): add, sub, mul #235

feat(atenlib): add, sub, mul #235

justinchuby commented Dec 6, 2022 •

edited

Loading

justinchuby Dec 6, 2022

codecov bot commented Dec 6, 2022 •

edited

Loading

github-advanced-security bot left a comment

gramalingam Dec 6, 2022

justinchuby Dec 6, 2022

justinchuby Dec 6, 2022

justinchuby Dec 7, 2022

gramalingam Dec 6, 2022

gramalingam Dec 6, 2022

fatcat-z left a comment

		return op.Mul(self, other)


		def aten_mul_bool(self: TensorType, other: TensorType) -> TensorType:

		return op.Mul(self, other)


		def aten_mul_bool(self: BOOL, other: BOOL) -> BOOL:

feat(atenlib): add, sub, mul #235

feat(atenlib): add, sub, mul #235

Conversation

justinchuby commented Dec 6, 2022 • edited Loading

justinchuby Dec 6, 2022

Choose a reason for hiding this comment

codecov bot commented Dec 6, 2022 • edited Loading

Codecov Report

github-advanced-security bot left a comment

Choose a reason for hiding this comment

gramalingam Dec 6, 2022

Choose a reason for hiding this comment

justinchuby Dec 6, 2022

Choose a reason for hiding this comment

justinchuby Dec 6, 2022

Choose a reason for hiding this comment

justinchuby Dec 7, 2022

Choose a reason for hiding this comment

gramalingam Dec 6, 2022

Choose a reason for hiding this comment

gramalingam Dec 6, 2022

Choose a reason for hiding this comment

fatcat-z left a comment

Choose a reason for hiding this comment

justinchuby commented Dec 6, 2022 •

edited

Loading

codecov bot commented Dec 6, 2022 •

edited

Loading