Skip to content

feat(atenlib): typing module #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Dec 6, 2022
Merged

feat(atenlib): typing module #233

merged 38 commits into from
Dec 6, 2022

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Dec 5, 2022 •
edited
Loading

@justinchuby
feat(atenlib): establish the aten-lib directory
2c8ee88 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): establish the aten-lib dire…
40af0b4 
…ctory"

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): establish the aten-lib directory"
ee554d7 
[ghstack-poisoned]
@justinchuby
feat(atenlib): Create sample functions and tests
fa8ce18 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): Create sample functions and…
6d426b5 
… tests with OpInfo"

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): Create sample functions and tests with OpInfo"
bb9fbee 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): create tests with OpInfo"
0aed28e 
[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): create tests with OpInfo"
91aa327 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): create tests with OpInfo"
00a081b 
[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): create tests with OpInfo"
fce8072 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): create tests with OpInfo"
af56008 
[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): create tests with OpInfo"
8c0b370 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): create tests with OpInfo"
bfeaefc 
[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): create tests with OpInfo"
8dc3d15 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): create tests with OpInfo"
46aa719 
[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): create tests with OpInfo"
d87f309 
[ghstack-poisoned]
@justinchuby
feat: aten function signature generator
afa50e3 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): aten function signature gen…
1b2674d 
…erator"

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): aten function signature generator"
1861734 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): aten function signature gen…
64810de 
…erator"

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): aten function signature generator"
421e9e4 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): aten function signature gen…
c566e24 
…erator"

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): aten function signature generator"
15ecd59 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): aten function signature gen…
2ab2fc3 
…erator"

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): aten function signature generator"
91fb612 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): aten function signature gen…
d49a69d 
…erator"

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): aten function signature generator"
c7940b2 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): aten function signature gen…
4c2c2c6 
…erator"

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): aten function signature generator"
ed6baf7 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): aten function signature gen…
e5e4910 
…erator"

[ghstack-poisoned]
This was referenced Dec 5, 2022
Merged
Merged
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 5, 2022
View reviewed changes
@codecov
Copy link

codecov bot commented Dec 5, 2022 •
edited
Loading

Codecov Report

Merging #233 (7c2c722) into main (7c346d7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   75.54%   75.54%           
=======================================
  Files          89       89           
  Lines        7216     7216           
=======================================
  Hits         5451     5451           
  Misses       1765     1765

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@justinchuby justinchuby mentioned this pull request Dec 6, 2022
Merged
@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Dec 6, 2022
@justinchuby justinchuby requested a review from fatcat-z December 6, 2022 05:12
fatcat-z
fatcat-z reviewed Dec 6, 2022
View reviewed changes
onnxscript/function_libs/torch_aten/typing.py Outdated


FloatType = Union[FLOAT16, FLOAT, DOUBLE]
IntType = Union[INT16, INT32, INT64]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we have INT8 here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Added

fatcat-z
fatcat-z approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@justinchuby justinchuby changed the base branch from gh/justinchuby/6/base to main December 6, 2022 16:50
@justinchuby justinchuby merged commit af136f4 into main Dec 6, 2022
@justinchuby justinchuby deleted the gh/justinchuby/6/head branch December 6, 2022 18:15
Indie365 pushed a commit to Indie365/onnxscript that referenced this pull request Oct 26, 2023
@justinchuby
feat(atenlib): typing module
e959cda 
ghstack-source-id: 8174a22
Pull Request resolved: microsoft/onnxscript#233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatcat-z fatcat-z fatcat-z approved these changes

Assignees
No one assigned
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinchuby @fatcat-z