-
Notifications
You must be signed in to change notification settings - Fork 72
Avoid using fixed value for max_pos_ids in cos_sin_cache fusion #2167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1fa3150
to
0ef0388
Compare
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
gramalingam
reviewed
Apr 8, 2025
gramalingam
reviewed
Apr 8, 2025
gramalingam
reviewed
Apr 8, 2025
gramalingam
reviewed
Apr 8, 2025
gramalingam
reviewed
Apr 8, 2025
0ef0388
to
83cd139
Compare
83cd139
to
3fa77b4
Compare
3fa77b4
to
4efaea1
Compare
gramalingam
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To apply the cos sin fusion pattern-rewrite, we need to know the maximum position id.