-
Notifications
You must be signed in to change notification settings - Fork 72
[IR] Support specifying output value in Tape #2225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When a user wants to specify names for output values, they can initialize the value first then supply them to tape op() call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for specifying output values in Tape operations by allowing users to initialize and supply output values explicitly.
- Added an optional output parameter to op() to allow a single output value specification.
- Extended op_multi_output() with optional outputs in addition to num_outputs, with validation to ensure at least one is provided.
❌ 17 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any examples/documentation illustrating the creation of output value and then using it to create an op?
Will create as a follow up, thanks! |
When a user wants to specify names for output values, they can initialize the value first then supply them to tape op() call.
Also renamed symbolic_multi_output to symblic_multi_out to match https://pytorch.org/docs/main/onnx_ops.html#torch.onnx.ops.symbolic_multi_out