Skip to content

[IR] Support specifying output value in Tape #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions onnxscript/ir/_tape.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,17 +86,23 @@
name: str | None = None,
doc_string: str | None = None,
metadata_props: dict[str, str] | None = None,
output: ir.Value | None = None,
) -> ir.Value:
if attributes is None:
attrs: Sequence[ir.Attr | ir.RefAttr] = ()
else:
attrs = _convenience.convert_attributes(attributes)
output_kwargs: dict[str, Any]
if output is None:
output_kwargs = dict(num_outputs=1)
else:
output_kwargs = dict(outputs=[output])

Check warning on line 99 in onnxscript/ir/_tape.py

View check run for this annotation

Codecov / codecov/patch

onnxscript/ir/_tape.py#L99

Added line #L99 was not covered by tests
node = ir.Node(
domain,
op_type,
inputs,
attributes=attrs,
num_outputs=1,
**output_kwargs,
overload=overload,
version=version,
graph=graph or self.graph_like,
Expand All @@ -109,13 +115,14 @@

return node.outputs[0]

def op_multi_output(
def op_multi_out(
self,
op_type: str,
inputs: Sequence[ir.Value | None],
attributes: Mapping[str, _convenience.SupportedAttrTypes] | None = None,
*,
num_outputs: int,
num_outputs: int | None = None,
outputs: Sequence[ir.Value] | None = None,
domain: str = "",
overload: str = "",
version: int | None = None,
Expand All @@ -124,6 +131,15 @@
doc_string: str | None = None,
metadata_props: dict[str, str] | None = None,
) -> Sequence[ir.Value]:
if num_outputs is None and outputs is None:
raise ValueError("Either num_outputs or outputs must be provided.")

Check warning on line 135 in onnxscript/ir/_tape.py

View check run for this annotation

Codecov / codecov/patch

onnxscript/ir/_tape.py#L135

Added line #L135 was not covered by tests
if num_outputs is not None and outputs is not None:
raise ValueError("Both num_outputs and outputs cannot be provided simultaneously.")

Check warning on line 137 in onnxscript/ir/_tape.py

View check run for this annotation

Codecov / codecov/patch

onnxscript/ir/_tape.py#L137

Added line #L137 was not covered by tests
output_kwargs: dict[str, Any]
if outputs is None:
output_kwargs = dict(num_outputs=num_outputs)
else:
output_kwargs = dict(outputs=outputs)

Check warning on line 142 in onnxscript/ir/_tape.py

View check run for this annotation

Codecov / codecov/patch

onnxscript/ir/_tape.py#L142

Added line #L142 was not covered by tests
if attributes is None:
attrs: Sequence[ir.Attr | ir.RefAttr] = ()
else:
Expand All @@ -133,7 +149,7 @@
op_type,
inputs,
attributes=attrs,
num_outputs=num_outputs,
**output_kwargs,
overload=overload,
version=version,
graph=graph or self.graph_like,
Expand Down Expand Up @@ -183,7 +199,7 @@
if isinstance(outputs, Sequence):
value.name = outputs[0]
return value
values = super().op_multi_output(
values = super().op_multi_out(
op_type,
inputs=inputs,
attributes=kwargs,
Expand Down
2 changes: 1 addition & 1 deletion onnxscript/ir/_tape_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def test_op_multi_out(self):

tape = ir.tape.Tape()

out1, out2, out3 = tape.op_multi_output("SomeOp", inputs=inputs, num_outputs=3) # pylint: disable=unbalanced-tuple-unpacking
out1, out2, out3 = tape.op_multi_out("SomeOp", inputs=inputs, num_outputs=3) # pylint: disable=unbalanced-tuple-unpacking
_ = tape.op("SomeOtherOp", inputs=[out1, out2, out3])

self.assertEqual([n.op_type for n in tape.nodes], ["SomeOp", "SomeOtherOp"])
Expand Down
Loading