Skip to content

Re-enable fused matmul rules #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

bmehta001
Copy link
Contributor

Enable fused matmul rules again, since they were commented out

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Re-enables the previously commented-out fused MatMul rewrite rules and updates a typo in its docstring.

  • Correct the docstring from “contrib obs” to “contrib ops” and fix indentation.
  • Import and include the fused_matmul_rule_sets rules in the core fusion rule list.
  • Remove the old commented-out invocation and replace it with the active rule set.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
onnxscript/rewriter/ort_fusions/fused_matmul_rule_sets.py Updated docstring and re-enabled fused MatMul rules
onnxscript/rewriter/ort_fusions/_core.py Imported and added the fused_matmul rules to list
Comments suppressed due to low confidence (1)

onnxscript/rewriter/ort_fusions/_core.py:41

  • Newly re-enabled fused MatMul rules aren’t covered by existing tests. Please add unit or integration tests to verify these rules are applied correctly during model rewriting.
*fused_matmul_rule_sets.fused_matmul_rule_sets().rules,

Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.14%. Comparing base (cabd83b) to head (2a557ae).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2370   +/-   ##
=======================================
  Coverage   70.13%   70.14%           
=======================================
  Files         197      197           
  Lines       24982    24983    +1     
  Branches     2667     2667           
=======================================
+ Hits        17522    17525    +3     
+ Misses       6532     6531    -1     
+ Partials      928      927    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmehta001 bmehta001 merged commit 51ecf47 into microsoft:main Jun 10, 2025
28 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants